Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[18.0][MIG] account_move_line_purchase_info: Migration to 18.0 #2029

Open
wants to merge 73 commits into
base: 18.0
Choose a base branch
from
Open

[18.0][MIG] account_move_line_purchase_info: Migration to 18.0 #2029

wants to merge 73 commits into from

Conversation

IsabelAForgeFlow
Copy link

Migration to 18.0

JordiBForgeFlow and others added 30 commits February 11, 2025 16:54
@JordiBForgeFlow @IsabelAForgeFlow
module 'account_move_line_purchase_info'
819ef9b
@oca-transbot @IsabelAForgeFlow
OCA Transbot updated translations from Transifex
9bf78e8
@LoisRForgeFlow @IsabelAForgeFlow
[MIG] account_move_line_purchase_info
f5b8916
@LoisRForgeFlow @IsabelAForgeFlow
[FIX] moved method and fields.
b14ade9
@LoisRForgeFlow @IsabelAForgeFlow
[FIX] odoo imports
11b7e2a
@LoisRForgeFlow @IsabelAForgeFlow
[11.0][MIG] account_move_line_purchase_info
0299203
@oca-travis @IsabelAForgeFlow
[UPD] Update account_move_line_purchase_info.pot
e231d99
@rschnapka @IsabelAForgeFlow
Translated using Weblate (German)
585e0c2 
Currently translated at 100,0% (5 of 5 strings)

Translation: account-financial-tools-11.0/account-financial-tools-11.0-account_move_line_purchase_info
Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-11-0/account-financial-tools-11-0-account_move_line_purchase_info/de/
@AdriaGForgeFlow @IsabelAForgeFlow
[12.0][MIG] Migrate module account_move_line_purchase_info to v12
b8f1831
@OCA-git-bot @IsabelAForgeFlow
[UPD] README.rst
2bf5aa6
@oca-travis @IsabelAForgeFlow
[UPD] Update account_move_line_purchase_info.pot
116d17a
@oca-transbot @IsabelAForgeFlow
Update translation files
58b9156 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: account-financial-tools-12.0/account-financial-tools-12.0-account_move_line_purchase_info
Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-12-0/account-financial-tools-12-0-account_move_line_purchase_info/
@eduaparicio @IsabelAForgeFlow
Translated using Weblate (Portuguese (Brazil))
20cc870 
Currently translated at 100.0% (5 of 5 strings)

Translation: account-financial-tools-12.0/account-financial-tools-12.0-account_move_line_purchase_info
Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-12-0/account-financial-tools-12-0-account_move_line_purchase_info/pt_BR/
@sbidoul @IsabelAForgeFlow
[FIX] bump version account_move_line_purchase_info
bf0f62e 
To force wheel regeneration, because the
currently published wheel wrongly
depends on odoo12-addon-purchase_stock
which is a standard Odoo module.
@OCA-git-bot @IsabelAForgeFlow
[UPD] README.rst
180b9bb
@JordiBForgeFlow @IsabelAForgeFlow
forward port latest changes from 11.0
5df2224
@oca-travis @IsabelAForgeFlow
[UPD] Update account_move_line_purchase_info.pot
4a4107c
@oca-transbot @IsabelAForgeFlow
Update translation files
465d951 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: account-financial-tools-12.0/account-financial-tools-12.0-account_move_line_purchase_info
Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-12-0/account-financial-tools-12-0-account_move_line_purchase_info/
@pedrocs-exo @IsabelAForgeFlow
Translated using Weblate (Portuguese)
2c0a475 
Currently translated at 100.0% (5 of 5 strings)

Translation: account-financial-tools-12.0/account-financial-tools-12.0-account_move_line_purchase_info
Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-12-0/account-financial-tools-12-0-account_move_line_purchase_info/pt/
@IsabelAForgeFlow
Translated using Weblate (Portuguese (Brazil))
61480c6 
Currently translated at 100.0% (6 of 6 strings)

Translation: account-financial-tools-12.0/account-financial-tools-12.0-account_move_line_purchase_info
Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-12-0/account-financial-tools-12-0-account_move_line_purchase_info/pt_BR/
@AdriaGForgeFlow @IsabelAForgeFlow
[IMP] account_move_line_purchase_info: black, isort
37892f1
@AdriaGForgeFlow @IsabelAForgeFlow
[MIG] account_move_line_purchase_info: Migration to 13.0
cdcc2f6
@oca-travis @IsabelAForgeFlow
[UPD] Update account_move_line_purchase_info.pot
f4e9696
@oca-transbot @IsabelAForgeFlow
Update translation files
091a5be 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: account-financial-tools-13.0/account-financial-tools-13.0-account_move_line_purchase_info
Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-13-0/account-financial-tools-13-0-account_move_line_purchase_info/
@HviorForgeFlow @IsabelAForgeFlow
[FIX] account_move_line_purchase_info: Overwrite _compute_invoice to …
5ad9a28 
…ensure invoice count consistency
@oca-travis @IsabelAForgeFlow
[UPD] Update account_move_line_purchase_info.pot
c1e6fa3
@OCA-git-bot @IsabelAForgeFlow
[UPD] README.rst
4175a79
@oca-transbot @IsabelAForgeFlow
Update translation files
e552e93 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: account-financial-tools-13.0/account-financial-tools-13.0-account_move_line_purchase_info
Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-13-0/account-financial-tools-13-0-account_move_line_purchase_info/
@OCA-git-bot @IsabelAForgeFlow
pre-commit update
662cb34
@kittiu @IsabelAForgeFlow
[13.0][MIG] account_document_reversal
936e9f8
oca-ci and others added 15 commits February 11, 2025 16:54
@IsabelAForgeFlow
[UPD] Update account_move_line_purchase_info.pot
add4be2
@OCA-git-bot @IsabelAForgeFlow
[UPD] README.rst
fa6b14b
@Gelo-fl @IsabelAForgeFlow
Translated using Weblate (Spanish)
882ee84 
Currently translated at 100.0% (7 of 7 strings)

Translation: account-financial-tools-16.0/account-financial-tools-16.0-account_move_line_purchase_info
Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-16-0/account-financial-tools-16-0-account_move_line_purchase_info/es/
@badbole @IsabelAForgeFlow
Translated using Weblate (Croatian)
1d5cfdb 
Currently translated at 100.0% (7 of 7 strings)

Translation: account-financial-tools-16.0/account-financial-tools-16.0-account_move_line_purchase_info
Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-16-0/account-financial-tools-16-0-account_move_line_purchase_info/hr/
@adrianojprado @IsabelAForgeFlow
Translated using Weblate (Portuguese (Brazil))
a299084 
Currently translated at 100.0% (7 of 7 strings)

Translation: account-financial-tools-16.0/account-financial-tools-16.0-account_move_line_purchase_info
Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-16-0/account-financial-tools-16-0-account_move_line_purchase_info/pt_BR/
@OCA-git-bot @IsabelAForgeFlow
[UPD] README.rst
bb90c49
@weblate @IsabelAForgeFlow
Update translation files
7a1e3bd 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: account-financial-tools-16.0/account-financial-tools-16.0-account_move_line_purchase_info
Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-16-0/account-financial-tools-16-0-account_move_line_purchase_info/
@adrianojprado @IsabelAForgeFlow
Translated using Weblate (Portuguese (Brazil))
895e2ce 
Currently translated at 100.0% (7 of 7 strings)

Translation: account-financial-tools-16.0/account-financial-tools-16.0-account_move_line_purchase_info
Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-16-0/account-financial-tools-16-0-account_move_line_purchase_info/pt_BR/
@mymage @IsabelAForgeFlow
Translated using Weblate (Italian)
3686340 
Currently translated at 100.0% (7 of 7 strings)

Translation: account-financial-tools-16.0/account-financial-tools-16.0-account_move_line_purchase_info
Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-16-0/account-financial-tools-16-0-account_move_line_purchase_info/it/
@jakobkrabbe @IsabelAForgeFlow
Translated using Weblate (Swedish)
ea0fcc3 
Currently translated at 100.0% (7 of 7 strings)

Translation: account-financial-tools-16.0/account-financial-tools-16.0-account_move_line_purchase_info
Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-16-0/account-financial-tools-16-0-account_move_line_purchase_info/sv/
@JasminSForgeFlow @IsabelAForgeFlow
[IMP] account_move_line_purchase_info: black, isort, prettier
8d14f8e
@JasminSForgeFlow @IsabelAForgeFlow
[MIG] account_move_line_purchase_info: Migration to 17.0
d785633
@IsabelAForgeFlow
[UPD] Update account_move_line_purchase_info.pot
a1a1aba
@OCA-git-bot @IsabelAForgeFlow
[BOT] post-merge updates
f7629ce
@IsabelAForgeFlow
[IMP] account_move_line_purchase_info: pre-commit auto fixes
f43e87e
AlexPForgeFlow
AlexPForgeFlow approved these changes Feb 17, 2025
View reviewed changes
Copy link
Contributor

@AlexPForgeFlow AlexPForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional and code review! 👍

MiquelRForgeFlow
MiquelRForgeFlow reviewed Feb 17, 2025
View reviewed changes
account_move_line_purchase_info/models/purchase_order_line.py Outdated
class PurchaseOrderLine(models.Model):
_inherit = "purchase.order.line"

def name_get(self):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. Please cherry-pick #2030.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have done the cherry-pick of your fix. Thanks for reviewing it :)

@IsabelAForgeFlow IsabelAForgeFlow force-pushed the 18.0-mig-account_move_line_purchase_info branch from 9262d89 to 808b53c Compare February 17, 2025 15:50
AaronHForgeFlow
AaronHForgeFlow reviewed Feb 17, 2025
View reviewed changes
Copy link
Contributor

@AaronHForgeFlow AaronHForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review LG. Just pending to fix some minor lint issues:


account_move_line_purchase_info/tests/test_account_move_line_purchase_info.py:216:89: E501 Line too long (91 > 88)
    |
214 |                 (
215 |                     po_line.id,
216 |                     f"[{po_line.order_id.name}] {po_line.name} ({po_line.order_id.state})",
    |                                                                                         ^^^ E[50](https://github.com/OCA/account-financial-tools/actions/runs/13374064708/job/37351740605?pr=2029#step:7:51)1
217 |                 )
218 |             ],
    |

Found 1 error.

@IsabelAForgeFlow IsabelAForgeFlow force-pushed the 18.0-mig-account_move_line_purchase_info branch from 808b53c to c324ec3 Compare February 18, 2025 14:06
@IsabelAForgeFlow IsabelAForgeFlow mentioned this pull request Feb 19, 2025
Open
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

AaronHForgeFlow
AaronHForgeFlow approved these changes Feb 22, 2025
View reviewed changes
Copy link
Contributor

@AaronHForgeFlow AaronHForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional 👍

@AaronHForgeFlow
Copy link
Contributor

It seems there is still a pre-commit issue

@IsabelAForgeFlow IsabelAForgeFlow force-pushed the 18.0-mig-account_move_line_purchase_info branch from c324ec3 to 3278c2a Compare February 24, 2025 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AaronHForgeFlow AaronHForgeFlow AaronHForgeFlow approved these changes

@MiquelRForgeFlow MiquelRForgeFlow MiquelRForgeFlow approved these changes

@AlexPForgeFlow AlexPForgeFlow AlexPForgeFlow approved these changes

Assignees
No one assigned
Labels
approved ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.