Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] website_account_fiscal_position_partner_type: Show B2B/B2C information in sign up page #885

Conversation

manuelregidor
Copy link

This improvement applies 2 changes:

  1. It changes the location of the Partner Type field in the signup view. It is now underneath the email field, so it becomes the second field in the form.
    website_account_fiscal_position_partner_type_1_

  2. It adds the possibility of showing a message underneath the Partner Type field in the signup view. This message can be customised from the website configuration view and it can be different depenending on the chosen option. The message has to be set in HTML.

website_account_fiscal_position_partner_type_2
website_account_fiscal_position_partner_type_3
website_account_fiscal_position_partner_type_4

The reason why we propose this improvement is because some of our customers have noticed that sometimes, website users do not fully know the difference between being a B2B or a B2C customer, so adding information to make it clear could be helpful for them. Also, as the name they introduce when registering might depend on the B2B/B2C choice, placing this before the name field could also prevent them from making mistakes.

@manuelregidor
Copy link
Author

Copy link

@ValentinVinagre ValentinVinagre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

Copy link

@HaraldPanten HaraldPanten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HaraldPanten
Copy link

@pedrobaeza @etobella do you mind merging these changes?

THX!

@etobella
Copy link
Member

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 15.0-ocabot-merge-pr-885-by-etobella-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit c1974c6 into OCA:15.0 Jan 18, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 5df3d9a. Thanks a lot for contributing to OCA. ❤️

@HaraldPanten HaraldPanten deleted the 15.0-imp-website_account_fiscal_position_partner_type branch January 18, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants