-
-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16][REF] split web_view_leaflet_map into web_view_leaflet_map and web_leaflet_lib #380
[16][REF] split web_view_leaflet_map into web_view_leaflet_map and web_leaflet_lib #380
Conversation
web_view_leaflet_map/__manifest__.py
Outdated
@@ -4,8 +4,7 @@ | |||
|
|||
{ | |||
"name": "Leaflet Map View (OpenStreetMap)", | |||
"summary": "Integrate leaflet.js librairy with odoo" | |||
" and add new 'leaflet_map' view, to display markers.", | |||
"summary": "Add new 'leaflet_map' view, to display markers.", | |||
"version": "16.0.1.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Version to raise?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Version to raise?
Sorry. I don't understand.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I get it ! Done.
Can be merged now, @yvaucher . Thanks for your review !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functional review
This PR has the |
…aflet_lib, to be used by other modules, like 'web_widget_map'. (see : OCA/web#2953)
e1073ec
to
d87a77f
Compare
/ocabot merge nobump |
Sorry @legalsylvain you are not allowed to merge. To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons. If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the |
@yvaucher could you "ocabot merge nobump" here ? thanks ! |
/ocabot merge nobump Here we go. |
On my way to merge this fine PR! |
Congratulations, your PR was merged at 6018cdc. Thanks a lot for contributing to OCA. ❤️ |
- Bump version. - Remove obsolete hook. (that was usefull during the refactoring done here OCA#380)
- Bump version. - Remove obsolete hook. (that was usefull during the refactoring done here OCA#380)
To be used by other modules, like 'web_widget_map'. (see : OCA/web#2953)