Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16][REF] split web_view_leaflet_map into web_view_leaflet_map and web_leaflet_lib #380

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

legalsylvain
Copy link
Contributor

To be used by other modules, like 'web_widget_map'. (see : OCA/web#2953)

@@ -4,8 +4,7 @@

{
"name": "Leaflet Map View (OpenStreetMap)",
"summary": "Integrate leaflet.js librairy with odoo"
" and add new 'leaflet_map' view, to display markers.",
"summary": "Add new 'leaflet_map' view, to display markers.",
"version": "16.0.1.0.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Version to raise?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Version to raise?

Sorry. I don't understand.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get it ! Done.

Can be merged now, @yvaucher . Thanks for your review !

Copy link

@florian-dacosta florian-dacosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

…aflet_lib, to be used by other modules, like 'web_widget_map'. (see : OCA/web#2953)
@legalsylvain legalsylvain force-pushed the 16.0-REF-split-into-web_leaflet_lib branch from e1073ec to d87a77f Compare October 23, 2024 18:37
@legalsylvain
Copy link
Contributor Author

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Sorry @legalsylvain you are not allowed to merge.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

@legalsylvain
Copy link
Contributor Author

@yvaucher could you "ocabot merge nobump" here ?

thanks !

@yvaucher
Copy link
Member

/ocabot merge nobump

Here we go.

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-380-by-yvaucher-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 3c1f22c into OCA:16.0 Oct 29, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 6018cdc. Thanks a lot for contributing to OCA. ❤️

legalsylvain added a commit to grap/geospatial that referenced this pull request Oct 29, 2024
- Bump version.
- Remove obsolete hook. (that was usefull during the refactoring done here OCA#380)
legalsylvain added a commit to grap/geospatial that referenced this pull request Oct 29, 2024
- Bump version.
- Remove obsolete hook. (that was usefull during the refactoring done here OCA#380)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants