[16.0][MIG] l10n_de_tax_statement_zm #146
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrGigSolutions
force-pushed
the
16.0-mig-l10n_de_tax_statement_zm
branch
from
73de101 to
edca8ae
Compare
MrGigSolutions
force-pushed
the
16.0-mig-l10n_de_tax_statement_zm
branch
from
edca8ae to
15699a7
Compare
|
I suspect the failing tests are because there are 4 demo invoices installed, these were not there in earlier versions. Think this should be corrected in datev_import_csv_dtvf. |
|
@ortlam, would you mind having a look at this one? |
|
@ortlam would you mind to fix this ? |
we have cloned and adopted the l10n-netherlands tax report module from Onestein B.V. The report is constructed in the same way as official german „Umsatzsteuervoranmeldung“. The values from the report could be easily transmitted via official portal https://www.elster.de/ in order to declare and transfer your monthly (or quarterly) vat taxes.
…fig wizard most removed tests are not relevant for germany as they was related in the clone from netherlands to invoice basis (related to invoice or account move dates which is probably not relevant for germany). The change in the config wizard was required as the tax tag mappings for the tax statement should work with skr03 and skr04 accounting plans.
The prior change raised an error. The two additional dependencies account_invoicing, l10n_de should help to allow immediate runbot testing without any manual installation steps in advance.
I have applied proposed changes of Andrea Stirpe in order to get through the testing procedure.
The old lines 39 disappeared and was merged together with the old line 40 (now they are line 39 in 2019 edition). Furthermore the old lines 49 and 51 disappeared and was merged into the line 50. There is a relevance for the tax codes (tag_ids). The old tag „USt-VA KZ 68“ have to be mapped to the same line as the tag „USt-VA KZ 60“. The old tags „USt-VA KZ 52“ and „USt-VA KZ 78“ have to be mapped the same way as the old and single remaining „USt-VA 84“ (= base values). The old tags „USt-VA KZ 53“ and „USt-VA KZ 79“ have to be mapped the same way as the old and single remaining „USt-VA KZ 85“ (tax values). Furthermore we might have formatting changes caused by the different line numbering. Therefore i expect further adoptions in the files „l10n_de_tax_statement_line.py“ and also in the „l10n_de_tax_statement_config_wizard.xml“ and the „l10n_de_tax_statement_config_wizard.py“. I assume we cannot avoid deeper changes in order to adopt what we really want.
… compare conversation: OCA#39
Changes: - Adjusted manifest - Removed migrations - Refactored unlink() to @api.ondelete - Removed unused methods and imports from tests - Tests now use setUpClass instead of setUp - Removed widgets from chatter
MrGigSolutions
force-pushed
the
16.0-mig-l10n_de_tax_statement_zm
branch
from
15699a7 to
7b020f9
Compare
…nde Meldung) This module extends the *German VAT Statement* module (Umsatzsteuervoranmeldung), by adding the statement for the *Intra-Community transactions declaration* (Zusammenfassende Meldung). As for the German VAT declaration this module is a cloned adoption from Onestein’s OCA module 10n_nl_vat_statement_icp. This report is based on the line *Steuerfr. Umsätze mit Vorsteuerabz. innerg. Lieferungen (§4 Nr. 1b) an Abnehmer mit USt-ID (41)* and *Nicht steuerb. sonst. Leist. gem. § 18b S. 1 Nr. 2 (21)* of the German VAT Statement report. The period is also the same as the one selected in the VAT statement report. This additional VAT declaration report includes: * the VAT identification numbers of your customers * the total amount of intra-Community supplies from Germany for every customer during the selected period * The values for product deliveries and services are separated in two columns. * If you want to transmit the values to the official report form, f.e. by "www.elster.de" you would have to enter two lines if both columns product + services contains values.
************* Module l10n_de_toponyms l10n_de_toponyms/wizard/l10n_de_toponyms_zipcodes.xml:1: [W7930(file-not-used), ] not used from manifest ************* Module l10n_de_tax_statement_zm l10n_de_tax_statement_zm/readme/USAGE.rst:5: [E7901(rst-syntax-error), ] Enumerated list ends without a blank line; unexpected unindent. l10n_de_tax_statement_zm/readme/USAGE.rst:5: [E7901(rst-syntax-error), ] Inline emphasis start-string without end-string. l10n_de_tax_statement_zm/readme/USAGE.rst:5: [E7901(rst-syntax-error), ] Inline emphasis start-string without end-string. ----------------------------------- Your code has been rated at 9.87/10
I have applied proposed changes of Andrea Stirpe in order to get through the testing procedure.
MrGigSolutions
force-pushed
the
16.0-mig-l10n_de_tax_statement_zm
branch
from
7b020f9 to
9b6bba2
Compare
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small changes to tests only.
Because this modules depends on l10n_de_tax_statement, this PR is based off the PR that migrates that module to 16.0: #144