[IMP] l10n_it_fiscalcode: update library to check fiscalcode #4511
Conversation
|
@francesco-ooops grazie stavo correggendo anche i dati di test di fatturapa_in e import_zip che hanno un codicefiscale errato per l'intermediario |
patrickt-oforce
force-pushed
the
16.0-IMP-l10n_it_fiscalcode
branch
2 times, most recently
from
aab964f to
9b9e594
Compare
|
@SirAionTech issue aperta e linkata |
| nat_code = self._get_national_code( | ||
| f.birth_city.name, f.birth_province.code, f.birth_date | ||
| ) | ||
| if not nat_code: | ||
| raise UserError(_("National code is missing")) | ||
| c_f = build( | ||
|
|
||
| if isinstance(f.birth_date, datetime.date): |
There was a problem hiding this comment.
Il campo birth_date può essere una stringa?
There was a problem hiding this comment.
La libreria proposta deve ricevere il valore di birth_date come stringa
There was a problem hiding this comment.
Ma in che caso il campo birth_date = fields.Date("Date of birth", required=True) può contenere una stringa?
There was a problem hiding this comment.
Scusami ma credo che non ci stiamo capendo; la libreria proposta vuole il valore del campo birth_date come stringa, il metodo per calcolare il CF richiede che il valore di birth_date sia datetime o str qui gli arriva come data e lo converto in str
…in files IT05979361218_003.xml and IT05979361218_004.xml
…al code in invoices of archive file
patrickt-oforce
force-pushed
the
16.0-IMP-l10n_it_fiscalcode
branch
from
9b9e594 to
ceb0add
Compare
|
@sergiocorato per caso si potrebbe mergiare? |
Update library to check if a partner fiscal is formally valid, using
python-codicefiscalelibrary that can validate a fiscalcode even if this is omocode.In this PR are included fix to test of
l10n_it_fatturapa_inel10n_it_fatturapa_import_zip, because try to validate the FC in xml, result to an error on check digit, make automated tests failing