Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[18.0][MIG] mail optional follower notification #37

Open
wants to merge 53 commits into
base: 18.0
Choose a base branch
from
Open

[18.0][MIG] mail optional follower notification #37

wants to merge 53 commits into from

Conversation

gdgellatly
Copy link
Contributor

@gdgellatly gdgellatly commented Feb 17, 2025 •
edited
Loading

Not so Standard migration.

There are changes to the message composition view upstream and a new widget. As such I have modified the view to try and suit, however a functional review would be useful, esp. in terms of the mail composer layout.

@gdgellatly
Copy link
Contributor Author

Note this replaces #11 which had some process errors

@gdgellatly
Copy link
Contributor Author

@pedrobaeza Sorry I need your help. I did process above, got a nice clean 52 commits, and have ended up requesting to merge 193 with all unrelated modules. Is it documented anywhere the process to move one repo to another?

@pedrobaeza
Copy link
Member

You don't have to cherry-pick, but apply the same git format-patch than the guide, but with 2 different remotes:

git remote add social [email protected]:OCA/social.git
git remote add origin [email protected]:OCA/mail.git
git fetch social 17.0
git fetch origin 18.0
git format-patch --keep-subject --stdout origin/18.0..social/17.0 -- mail_optional_follower_notification | git am -3 --keep

adrienpeiffer and others added 27 commits February 17, 2025 21:45
@adrienpeiffer
Add mail_optional_follower_notification module (#60)
4d05b7d 
* [ADD] Add mail_optional_follower_notifications module

* [CHG][mail_optional_follower_notifications] Readme.

* [IMP][mail_optional_follower_notifications] Code review.

* [CHG] Rename mail_optional_follower_notifications to mail_optional_follower_notification

* [IMP][mail_optional_follower_notification] Review
@lmignon
Upgrade version from 8 -> 9
c26ce30
@lmignon
mail.notification has been removed. The notify is done directly on th…
c5faa95 
…e res.partner and channel
@lmignon
Tests: Replace XML_IDs no more available in 9.0
605399c
@ThomasBinsfeld
Argument auto_commit in send_mail
85c716f
@adrienpeiffer
Migration of mail_optional_follower_notification to 10.0
29a0c9e
@adrienpeiffer
[FIX] Bad version
3506508
@sbidoul
[FIX] pep8
c2d39a2
@RobinetDenisAcsone
[IMP] Hide the checkbox for the mass mailing in mail_optional_followe…
fa57f86 
…r_notification and mail_optional_autofollow
@adrienpeiffer
[FIX] mail_optional_follower_notification: Check force_partners_to_no…
f7d4f12 
…tify instead of notify_followers.

Without this commit, followers are NEVER notified when a message is directly posted on the tracker (without click to open the mail compose message form)
@pedrobaeza
[FIX] README.rst syntax
4818e58
@marylla
Translated using Weblate (German)
bb1e581 
Currently translated at 100.0% (5 of 5 strings)

Translation: social-10.0/social-10.0-mail_optional_follower_notification
Translate-URL: https://translation.odoo-community.org/projects/social-10-0/social-10-0-mail_optional_follower_notification/de/
@pedrocs-exo
Translated using Weblate (Portuguese)
6f2e291 
Currently translated at 100.0% (5 of 5 strings)

Translation: social-10.0/social-10.0-mail_optional_follower_notification
Translate-URL: https://translation.odoo-community.org/projects/social-10-0/social-10-0-mail_optional_follower_notification/pt/
@astirpe
[12.0][MIG] mail_optional_follower_notification
2531c03
@lmignon
[IMP] mail_optional_follower_notification: black, isort
b96d524
@lmignon
[MIG] mail_optional_follower_notification: Migration to 13.0
405e721
@lmignon @isabellerichard
Update mail_optional_follower_notification/models/mail_thread.py
0c3ed26 
Co-authored-by: Isabelle RICHARD <[email protected]>
[IMP] pre-commit run -a
69b39d7
@glitchov
[13.0][FIX] mail_optional_follower_notification: change added span re…
95850bf 
…f in view
@ioans73
[IMP] mail_optional_follower_notification: black, isort, prettier
d7cc48a
@ioans73
[MIG] mail_optional_follower_notification: Migration to 14.0
77897c7
@oca-travis
[UPD] Update mail_optional_follower_notification.pot
2484de4
@OCA-git-bot
[UPD] README.rst
bb16779
@olgamarcocb
Translated using Weblate (Spanish)
bfe1e86 
Currently translated at 50.0% (2 of 4 strings)

Translation: social-14.0/social-14.0-mail_optional_follower_notification
Translate-URL: https://translation.odoo-community.org/projects/social-14-0/social-14-0-mail_optional_follower_notification/es/
@robin5210
[MIG] mail_optional_follower_notificatio: Migration to 15.0
945a0bd
[UPD] Update mail_optional_follower_notification.pot
dc99065
@OCA-git-bot
[UPD] README.rst
a4ed281
weblate and others added 16 commits February 17, 2025 21:45
@weblate
Update translation files
1643b7c 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: social-16.0/social-16.0-mail_optional_follower_notification
Translate-URL: https://translation.odoo-community.org/projects/social-16-0/social-16-0-mail_optional_follower_notification/
@mymage
Translated using Weblate (Italian)
73f6eba 
Currently translated at 100.0% (4 of 4 strings)

Translation: social-16.0/social-16.0-mail_optional_follower_notification
Translate-URL: https://translation.odoo-community.org/projects/social-16-0/social-16-0-mail_optional_follower_notification/it/
@adrianojprado
Translated using Weblate (Portuguese (Brazil))
2ee4c67 
Currently translated at 100.0% (4 of 4 strings)

Translation: social-16.0/social-16.0-mail_optional_follower_notification
Translate-URL: https://translation.odoo-community.org/projects/social-16-0/social-16-0-mail_optional_follower_notification/pt_BR/
@jdidderen-nsi
[IMP] mail_optional_follower_notification: pre-commit execution
03d7ea5
@jdidderen-nsi
[MIG] mail_optional_follower_notification: Migration to 17.0
727527f
[UPD] Update mail_optional_follower_notification.pot
d74764f
@OCA-git-bot
[BOT] post-merge updates
a5c42a9
@weblate
Update translation files
cf47012 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: social-17.0/social-17.0-mail_optional_follower_notification
Translate-URL: https://translation.odoo-community.org/projects/social-17-0/social-17-0-mail_optional_follower_notification/
@mymage
Translated using Weblate (Italian)
780f50e 
Currently translated at 100.0% (4 of 4 strings)

Translation: social-17.0/social-17.0-mail_optional_follower_notification
Translate-URL: https://translation.odoo-community.org/projects/social-17-0/social-17-0-mail_optional_follower_notification/it/
@AndrzejGerasimukARCHIMEDES
Translated using Weblate (Polish)
181e620 
Currently translated at 100.0% (4 of 4 strings)

Translation: social-17.0/social-17.0-mail_optional_follower_notification
Translate-URL: https://translation.odoo-community.org/projects/social-17-0/social-17-0-mail_optional_follower_notification/pl/
@Quan-nhm
[IMP] mail_optional_follower_notification: default notify followers
c1c13df 
Add a settings to set a default for the boolean 'Notifiy Followers' in the wizard
[UPD] Update mail_optional_follower_notification.pot
a9039ca
@OCA-git-bot
[BOT] post-merge updates
04fa1b5
@weblate
Update translation files
92e8414 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: social-17.0/social-17.0-mail_optional_follower_notification
Translate-URL: https://translation.odoo-community.org/projects/social-17-0/social-17-0-mail_optional_follower_notification/
@mymage
Translated using Weblate (Italian)
03c4e63 
Currently translated at 100.0% (7 of 7 strings)

Translation: social-17.0/social-17.0-mail_optional_follower_notification
Translate-URL: https://translation.odoo-community.org/projects/social-17-0/social-17-0-mail_optional_follower_notification/it/
[IMP] mail_optional_follower_notification: pre-commit auto fixes
f7bb112
@gdgellatly gdgellatly force-pushed the 18.0-mig-mail_optional_follower_notification branch 2 times, most recently from 085271e to 63649cd Compare February 17, 2025 08:52
@gdgellatly
Copy link
Contributor Author

OK Done, tyvm for your help

@gdgellatly gdgellatly force-pushed the 18.0-mig-mail_optional_follower_notification branch from 63649cd to c86de31 Compare February 17, 2025 08:56
@gdgellatly
Copy link
Contributor Author

Sorry, I am bit slow today, I migrated to v16 instead of v18. Will fix

@gdgellatly gdgellatly force-pushed the 18.0-mig-mail_optional_follower_notification branch 3 times, most recently from e7ff71a to f4bf729 Compare February 17, 2025 09:20
@gdgellatly gdgellatly changed the title 18.0 mig mail optional follower notification [18.0][MIG] mail optional follower notification Feb 18, 2025
@gdgellatly gdgellatly mentioned this pull request Feb 18, 2025
Open
@gdgellatly gdgellatly force-pushed the 18.0-mig-mail_optional_follower_notification branch 2 times, most recently from c995865 to f6c62f1 Compare February 18, 2025 21:18
@gdgellatly gdgellatly force-pushed the 18.0-mig-mail_optional_follower_notification branch from f6c62f1 to c1396aa Compare February 18, 2025 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.