[14.0][FIX] mail_template_multi_company: Don't set default company on mail template #485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…template Before this commit, this caused a bug that can be summarised as follows: 1. User A installs mail_template_multi_company. 2. User A installs another module, say, sale. 3. User A creates a new company and sets User B as a member of this (and only this) company. 4. User B tries to send an invoice. An error occurs at step 4 because of a bug at step 2. At step 2, when the sale module was installed, its mail template (which is used by all companies) defaulted to self.env.company, which was base.main_company. At step 4, using the mail template is forbidden for User B, because the template belongs to a company of which they are not a member. Removing the default value prevents this problem. Signed-off-by: Carmen Bianca BAKKER <[email protected]>
|
Hi @Olivier-LAURENT, |
|
@DaniilDigtyar ping :) |
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
MiquelRForgeFlow
approved these changes
Oct 26, 2023
|
Hi @Olivier-LAURENT, |
StefanRijnhart
approved these changes
Feb 3, 2025
|
/ocabot merge patch |
|
On my way to merge this fine PR! |
|
Congratulations, your PR was merged at 443fd82. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #483
Before this commit, this caused a bug that can be summarised as follows:
An error occurs at step 4 because of a bug at step 2. At step 2, when the sale module was installed, its mail template (which is used by all companies) defaulted to self.env.company, which was base.main_company. At step 4, using the mail template is forbidden for User B, because the template belongs to a company of which they are not a member.
Removing the default value prevents this problem.