[18.0][MIG] res_company_code: Migration to 18.0 #752

BhaveshHeliconia · 2024-12-26T11:40:36Z

Depends on:

[18.0][MIG] res_company_search_view: Migration to 18.0 #751

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: multi-company-13.0/multi-company-13.0-res_company_code Translate-URL: https://translation.odoo-community.org/projects/multi-company-13-0/multi-company-13-0-res_company_code/

Currently translated at 100.0% (5 of 5 strings) Translation: multi-company-13.0/multi-company-13.0-res_company_code Translate-URL: https://translation.odoo-community.org/projects/multi-company-13-0/multi-company-13-0-res_company_code/es/

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: multi-company-14.0/multi-company-14.0-res_company_code Translate-URL: https://translation.odoo-community.org/projects/multi-company-14-0/multi-company-14-0-res_company_code/

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: multi-company-16.0/multi-company-16.0-res_company_code Translate-URL: https://translation.odoo-community.org/projects/multi-company-16-0/multi-company-16-0-res_company_code/

Currently translated at 100.0% (5 of 5 strings) Translation: multi-company-16.0/multi-company-16.0-res_company_code Translate-URL: https://translation.odoo-community.org/projects/multi-company-16-0/multi-company-16-0-res_company_code/it/

amh-mw · 2024-12-28T16:39:10Z

res_company_code/models/res_company.py

    @api.model
    def name_search(self, name, args=None, operator="ilike", limit=100):
        args = args or []
        domain = []
        if name:
            domain = ["|", ("code", operator, name), ("name", operator, name)]
        company = self.search(domain + args, limit=limit)
-        return company.name_get()
+        return company._search_display_name()


_search_display_name has a different signature in the main Odoo codebase. Just move the one-liner here instead?

@amh-mw , Thank you for the suggestions! it's fixed can you rereview it?

amh-mw · 2025-01-04T13:48:51Z

res_company_code/models/res_company.py

+            if not company.code:
+                company.complete_name = company.name
+            else:
+                company.complete_name = f"{company.code} - {company.name}"


I wonder if this couldn't become _compute_display_name instead and the complete_name field dropped entirely. Worth consideration, but perhaps outside the scope of this migration. LGTM.

@amh-mw , Thank you for the suggestions! it's fixed can you rereview it?

amh-mw

Code review only. LGTM.

Christian-RB · 2025-01-27T11:32:53Z

Inside the test-requirements.txt file you should put the link to the PR involved with the next format, all in one line (Version >= 17):
odoo-addon-<module_name> @ git+https://github.com/OCA/<repository>.git@refs/pull/<PR_number>/head#subdirectory=<module_name>
For this case it should look like this:
odoo-addon-res_company_search_view @ git+https://github.com/OCA/multi-company.git@refs/pull/751/head#subdirectory=res_company_search_view

BhaveshHeliconia · 2025-02-03T07:08:33Z

@Christian-RB ,
I followed the correct format and added it to the test-requirements.txt, but it's still not working. Could you suggest any solutions or troubleshooting steps?

Christian-RB · 2025-02-04T13:05:00Z

@HeliconiaSolutions Check that the pre-commit is trying to edit the new file, maybe that's the reason

BhaveshHeliconia · 2025-02-06T09:07:11Z

@Christian-RB, I fixed the pre-commit issues and pushed my changes, but the pipeline is still failing in one case. Am I missing something? Could you guide me?

Thank you in advance!

Christian-RB · 2025-02-06T11:17:03Z

Everything is perfect now, @HeliconiaSolutions! The runboat has been created, and tests are passing. The only failing test is due to the pending dependency itself. Once the dependency is merged, you should remove the [DONT MERGE] commit, rebase and everything should turn green. Thank you

amh-mw

Code review only. LGTM.

Christian-RB

LGTM

BhaveshHeliconia · 2025-02-20T12:05:58Z

@legalsylvain, Can you please proceed with merging this PR?

legalsylvain · 2025-02-20T14:54:30Z

/ocabot migration res_company_code

@legalsylvain, Can you please proceed with merging this PR?

no. waiting for #751

BhaveshHeliconia · 2025-02-21T09:03:19Z

@legalsylvain , #751 has been merged. Could you take a look now?

legalsylvain · 2025-02-21T09:10:15Z

CI is red, because you should remove fe3745d now.

thanks !

BhaveshHeliconia · 2025-02-21T09:19:12Z

@legalsylvain, I've removed fe3745d, and the CI is green now. Please review. Thanks!

OCA-git-bot · 2025-02-21T09:21:15Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

legalsylvain · 2025-02-21T09:28:31Z

/ocabot merge nobump

OCA-git-bot · 2025-02-21T09:28:41Z

On my way to merge this fine PR!
Prepared branch 18.0-ocabot-merge-pr-752-by-legalsylvain-bump-nobump, awaiting test results.

OCA-git-bot · 2025-02-21T09:32:13Z

Congratulations, your PR was merged at e3072cc. Thanks a lot for contributing to OCA. ❤️

legalsylvain and others added 23 commits December 26, 2024 16:53

[ADD][12.0] new module res_company_code

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

GPG key ID: 4AEE18F83AFDEB23
Expired

Verified
Learn about vigilant mode

a9504b9

[UPD] Update res_company_code.pot, README.rst

45823e3

[IMP] res_company_code: black, isort, prettier

a773ffd

[MIG] res_company_code: Migration to v13.0

f7544cc

[UPD] Update res_company_code.pot

941cd5c

[UPD] README.rst

e5c966b

Update translation files

37c8151

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: multi-company-13.0/multi-company-13.0-res_company_code Translate-URL: https://translation.odoo-community.org/projects/multi-company-13-0/multi-company-13-0-res_company_code/

Added translation using Weblate (Spanish)

ba40c3d

Translated using Weblate (Spanish)

83b5ccf

Currently translated at 100.0% (5 of 5 strings) Translation: multi-company-13.0/multi-company-13.0-res_company_code Translate-URL: https://translation.odoo-community.org/projects/multi-company-13-0/multi-company-13-0-res_company_code/es/

[MIG] res_company_code: Migration to 14.0

b382179

[IMP] add name_search functionality, add tests

1e29d35

[UPD] Update res_company_code.pot

9c86f50

[UPD] README.rst

a6639c0

res_company_code 14.0.1.0.1

283275a

Update translation files

fb99224

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: multi-company-14.0/multi-company-14.0-res_company_code Translate-URL: https://translation.odoo-community.org/projects/multi-company-14-0/multi-company-14-0-res_company_code/

[MIG] res_company_code : migrate from 14.0 to 16.0

dc12039

[UPD] Update res_company_code.pot

4838a06

[BOT] post-merge updates

815c20c

Update translation files

db9ed71

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: multi-company-16.0/multi-company-16.0-res_company_code Translate-URL: https://translation.odoo-community.org/projects/multi-company-16-0/multi-company-16-0-res_company_code/

Added translation using Weblate (Italian)

9bba406

Translated using Weblate (Italian)

60e0c1a

Currently translated at 100.0% (5 of 5 strings) Translation: multi-company-16.0/multi-company-16.0-res_company_code Translate-URL: https://translation.odoo-community.org/projects/multi-company-16-0/multi-company-16-0-res_company_code/it/

[FIX] res_company_code: remove company_ids from demo partner

177429c

[IMP] res_company_code: pre-commit auto fixes

6749efc

amh-mw mentioned this pull request Dec 28, 2024

[18.0][MIG] res_company_code: Migration to 18.0 #745

Closed

amh-mw suggested changes Dec 28, 2024

View reviewed changes

BhaveshHeliconia force-pushed the 18.0-mig-res_company_code branch from 17444ba to d11047b Compare December 30, 2024 06:39

BhaveshHeliconia mentioned this pull request Dec 30, 2024

Migration to version 18.0 #705

Open

6 tasks

amh-mw approved these changes Jan 4, 2025

View reviewed changes

BhaveshHeliconia force-pushed the 18.0-mig-res_company_code branch from d11047b to d2a7a84 Compare January 24, 2025 06:14

amh-mw approved these changes Jan 24, 2025

View reviewed changes

BhaveshHeliconia force-pushed the 18.0-mig-res_company_code branch from 7d3ca64 to 03eedb4 Compare January 29, 2025 11:01

BhaveshHeliconia force-pushed the 18.0-mig-res_company_code branch from 03eedb4 to 4c0e8b0 Compare February 5, 2025 07:39

[MIG] res_company_code: Migration to 18.0

Loading
Loading status checks…

5943203

BhaveshHeliconia force-pushed the 18.0-mig-res_company_code branch from 4c0e8b0 to fe3745d Compare February 5, 2025 08:45

BhaveshHeliconia requested a review from amh-mw February 6, 2025 06:20

amh-mw approved these changes Feb 6, 2025

View reviewed changes

Christian-RB approved these changes Feb 6, 2025

View reviewed changes

OCA-git-bot added the approved label Feb 6, 2025

OCA-git-bot added this to the 18.0 milestone Feb 20, 2025

OCA-git-bot mentioned this pull request Feb 20, 2025

Migration to version 18.0 #782

Open

10 tasks

BhaveshHeliconia force-pushed the 18.0-mig-res_company_code branch from fe3745d to 5943203 Compare February 21, 2025 09:15

OCA-git-bot added the ready to merge label Feb 21, 2025

OCA-git-bot added the bot is merging ⏳ label Feb 21, 2025

OCA-git-bot merged commit 361adf2 into OCA:18.0 Feb 21, 2025
7 checks passed

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Feb 21, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[18.0][MIG] res_company_code: Migration to 18.0 #752

[18.0][MIG] res_company_code: Migration to 18.0 #752

BhaveshHeliconia commented Dec 26, 2024 •

edited

Loading

amh-mw Dec 28, 2024

BhaveshHeliconia Dec 30, 2024

amh-mw Jan 4, 2025

BhaveshHeliconia Jan 24, 2025

amh-mw left a comment

Christian-RB commented Jan 27, 2025

BhaveshHeliconia commented Feb 3, 2025

Christian-RB commented Feb 4, 2025

BhaveshHeliconia commented Feb 6, 2025

Christian-RB commented Feb 6, 2025

amh-mw left a comment

Christian-RB left a comment

BhaveshHeliconia commented Feb 20, 2025

legalsylvain commented Feb 20, 2025

BhaveshHeliconia commented Feb 21, 2025

legalsylvain commented Feb 21, 2025

BhaveshHeliconia commented Feb 21, 2025

OCA-git-bot commented Feb 21, 2025

legalsylvain commented Feb 21, 2025

OCA-git-bot commented Feb 21, 2025

OCA-git-bot commented Feb 21, 2025

[18.0][MIG] res_company_code: Migration to 18.0 #752

[18.0][MIG] res_company_code: Migration to 18.0 #752

Conversation

BhaveshHeliconia commented Dec 26, 2024 • edited Loading

amh-mw Dec 28, 2024

Choose a reason for hiding this comment

BhaveshHeliconia Dec 30, 2024

Choose a reason for hiding this comment

amh-mw Jan 4, 2025

Choose a reason for hiding this comment

BhaveshHeliconia Jan 24, 2025

Choose a reason for hiding this comment

amh-mw left a comment

Choose a reason for hiding this comment

Christian-RB commented Jan 27, 2025

BhaveshHeliconia commented Feb 3, 2025

Christian-RB commented Feb 4, 2025

BhaveshHeliconia commented Feb 6, 2025

Christian-RB commented Feb 6, 2025

amh-mw left a comment

Choose a reason for hiding this comment

Christian-RB left a comment

Choose a reason for hiding this comment

BhaveshHeliconia commented Feb 20, 2025

legalsylvain commented Feb 20, 2025

BhaveshHeliconia commented Feb 21, 2025

legalsylvain commented Feb 21, 2025

BhaveshHeliconia commented Feb 21, 2025

OCA-git-bot commented Feb 21, 2025

legalsylvain commented Feb 21, 2025

OCA-git-bot commented Feb 21, 2025

OCA-git-bot commented Feb 21, 2025

BhaveshHeliconia commented Dec 26, 2024 •

edited

Loading