[17.0][IMP] account_invoice_inter_company: Add pdf invoices in both companies #769
Conversation
| pdf = report._render_qweb_pdf(report.report_name, [self.id])[0] | ||
| self.env["ir.attachment"].create( | ||
| { | ||
| "name": self.name + ".pdf", |
There was a problem hiding this comment.
I'm thinking that the name may contain illegal characters for a file name, like /, so you should mask it. It may be also advisable to switch the method for self being the target invoice where the PDF is attached, as the method name suggest.
There was a problem hiding this comment.
I'm thinking that the name may contain illegal characters for a file name, like
/, so you should mask it.
Checking the process of creating an attachment through a report or sending an email, I confirm that no characters are replaced (although normally the name defined in the _get_report_base_filename() method is used so it has been changed).
It may be also advisable to switch the method for
selfbeing the target invoice where the PDF is attached, as the method name suggest.
I think changing the whole method to do the opposite can be even more confusing, IMO it is clear, from a sales invoice, you create the attachment and link it to the purchase invoice.
victoralmau
force-pushed
the
17.0-imp-account_invoice_inter_company-TT54805
branch
from
e40d996 to
8096567
Compare
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at 0cc8051. Thanks a lot for contributing to OCA. ❤️ |
FWP from 16.0: #766
Add pdf invoices in both companies
@Tecnativa TT54805