[16.0][MIG] sale_rental #2325

Murtaza-OSI · 2023-01-03T13:14:07Z

No description provided.

…the same SO as the rentals = the start date of the rentals, because we suppose that these products are "accessories" of the rental. Re-organise the order of some lines of code to make it more "logic".

…he module description.

Add POT file Add full FR translation for sale_start_end_dates Add partial FR translation for sale_rental Add pt_BR translation, contributed by Caio Barros.

…g because it means that, if you had sale_rental installed, you are missing the link betweek purchase order lines and invoice lines (for purchase orders created from pickings)

…es from products

…ew of sale order line, and instructions on how to do it Add demo data to automatically add admin and demo to group sale.group_mrp_properties, to have access to form view of sale order lines.

…a link to the screencast in the module description

…y of the rental features

Update POT file and FR translation Fix translated string in code Slovene translations added OCA Transbot updated translations from Transifex OCA Transbot updated translations from Transifex OCA Transbot updated translations from Transifex OCA Transbot updated translations from Transifex remove obsolete .pot files [ci skip] fix invalid pt_BR.po Update sale_rental.pot Translated using Weblate (Nederlands (nl_NL)) Currently translated at 100,0% (99 of 99 strings) Translation: sale-workflow-10.0/sale-workflow-10.0-sale_rental Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-10-0/sale-workflow-10-0-sale_rental/nl_NL/ Update sale_rental.pot Update translation files Updated by Actualizar ficheiros PO com o novo POT (msgmerge) hook in Weblate. Translated using Weblate (German) Currently translated at 28.3% (28 of 99 strings) Translation: sale-workflow-10.0/sale-workflow-10.0-sale_rental Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-10-0/sale-workflow-10-0-sale_rental/de/ [REM] Translation file for error

Add option to copy image from product to rental service default_code should not be a required field in rental service wizard Add help message on rental_qty field

Replace openerp by odoo in import declarations

…ot writeable

Convert readme to new subdir format

Standard migration + add some tests

Currently translated at 40.7% (42 of 103 strings) Translation: sale-workflow-15.0/sale-workflow-15.0-sale_rental Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-15-0/sale-workflow-15-0-sale_rental/fr_FR/

Currently translated at 63.1% (65 of 103 strings) Translation: sale-workflow-15.0/sale-workflow-15.0-sale_rental Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-15-0/sale-workflow-15-0-sale_rental/fr_FR/

Currently translated at 49.5% (51 of 103 strings) Translation: sale-workflow-15.0/sale-workflow-15.0-sale_rental Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-15-0/sale-workflow-15-0-sale_rental/fr/

chandni299 · 2023-01-05T09:33:40Z

Hello @Murtaza-OSI , If I am not wrong then we need to migrate the first module sale_start_end_dates to 16.0 as it is part of __manifest__.py file of module sale_rental here

rousseldenis · 2023-01-26T08:02:10Z

/ocabot migration sale_rental

pedrobaeza · 2023-08-14T10:15:06Z

This one should be definitively be moved to OCA/vertical-rental on this version.

Kev-Roche

Hi @Murtaza-OSI do you plan to fix this PR and move it top OCA/vertical-rental like suggested by @pedrobaeza ?
If no, I can do it.

Kev-Roche · 2023-12-14T13:06:09Z

sale_rental/tests/test_sale_rental.py

+        line_vals = {
+            "product_id": self.test_rental_prod.id,
+            "start_date": "2022-01-01",
+            "end_date": "2022-01-10",
+            "rental_qty": 1,
+        }
+
+        # with so_form.order_line.new() as line:
+        #     line.product_id = self.test_rental_prod
+        # line.start_date = "2022-01-01"
+        # line.end_date = "2022-01-10"
+        # line.rental_qty = 1
+        so = so_form.save()
+        so.write({"order_line": [(0, 0, line_vals)]})
+        sol = so.order_line


In order to play the onchange

Suggested change

line_vals = {

"product_id": self.test_rental_prod.id,

"start_date": "2022-01-01",

"end_date": "2022-01-10",

"rental_qty": 1,

}

# with so_form.order_line.new() as line:

# line.product_id = self.test_rental_prod

# line.start_date = "2022-01-01"

# line.end_date = "2022-01-10"

# line.rental_qty = 1

so = so_form.save()

so.write({"order_line": [(0, 0, line_vals)]})

sol = so.order_line

with so_form.order_line.new() as line:

line.product_id = self.test_rental_prod

line.start_date = "2022-01-01"

line.end_date = "2022-01-10"

line.rental_qty = 1

line.product_uom_qty = 10

so = so_form.save()

sol = so.order_line

Kev-Roche · 2023-12-14T13:07:37Z

sale_rental/tests/test_sale_rental.py

+        so = so_form.save()
+        so.write({"order_line": [(0, 0, line_vals)]})
+        sol = so.order_line
+        self.assertEqual(sol.price_subtotal, 60)


Suggested change

self.assertEqual(sol.price_subtotal, 60)

self.assertEqual(sol.price_subtotal, 600)

Kev-Roche · 2023-12-14T13:10:09Z

sale_rental/tests/test_sale_rental.py

+        line_vals = {
+            "product_id": self.test_rental_prod.rented_product_id.id,
+            "name": "Test",
+            "display_type": False,
+            "product_uom": self.env.ref("uom.product_uom_day").id,
+            "product_uom_qty": 1,
+            "sell_rental_id": rental,
+        }
+        so.write({"order_line": [(0, 0, line_vals)]})


The line values are already defined in the upper lines.

Suggested change

line_vals = {

"product_id": self.test_rental_prod.rented_product_id.id,

"name": "Test",

"display_type": False,

"product_uom": self.env.ref("uom.product_uom_day").id,

"product_uom_qty": 1,

"sell_rental_id": rental,

}

so.write({"order_line": [(0, 0, line_vals)]})

coffeinisfun · 2024-02-28T09:00:10Z

I have made a PR to move this module to OCA/vertical-rental like suggested by @pedrobaeza: OCA/vertical-rental#45

Alexis de Lattre and others added 30 commits January 3, 2023 18:38

Initial check-in of the rental project.

1e9e04a

We want to have the date_planned of the regular products that are on …

3bcc417

…the same SO as the rentals = the start date of the rentals, because we suppose that these products are "accessories" of the rental. Re-organise the order of some lines of code to make it more "logic".

Restrict to "day" UoM in the constraint. Add list of limitations in t…

7bdc000

…he module description.

Add read access on rental to stock user.

18fa2d4

[Translation]

36daa21

Add POT file Add full FR translation for sale_start_end_dates Add partial FR translation for sale_rental Add pt_BR translation, contributed by Caio Barros.

Missing call to super in _invoice_line_hook This bug was very annoyin…

3b4b9f7

…g because it means that, if you had sale_rental installed, you are missing the link betweek purchase order lines and invoice lines (for purchase orders created from pickings)

Better default values in the wizard for the creation of rental servic…

2920be7

…es from products

Add a note about the fact that you need to have access to the form vi…

6bf34f3

…ew of sale order line, and instructions on how to do it Add demo data to automatically add admin and demo to group sale.group_mrp_properties, to have access to form view of sale order lines.

FIX my commit revno 9 on the wizard to create the rental service Add …

de782e9

…a link to the screencast in the module description

Port to v8 and new API with several enhancements

c836577

Fix typo

9258f11

Inherit of product_id_change on product_id field, for better usabilit…

4def2d7

…y of the rental features

Fix flake8 warnings

a99feb6

Fix spelling mistake notified by @jbeficent

6256dc9

Take into account the remarks of Jordi Ballester

3561cc5

Add option to copy image from product to rental service default_code should not be a required field in rental service wizard Add help message on rental_qty field

FIX Tax on sale order lines

b2848e4

FIX the "0" qty by default in sale order lines

dd56b2b

Add missing default oca icons

a2f3057

prefix versions with 8.0

70d4f66

Make modules uninstallable

bec6ff7

Rename manifest files

c80a2ad

Port sale_start_end_dates and sale_rental (OCA#353)

0f5d788

sale_start_end_dates and sale_rental

4f8abd7

Product qty on rental pickings

a983c1c

Replace openerp by odoo in import declarations

Auto configure sale_rental module via post_install.py script

513d3f1

sale_rental: fix warning @constrains parameter 'must_have_dates' is n…

2f9ede7

…ot writeable

pylint

4309ce4

sale_rental: Migration to 11.0

a8f91be

[MIG] sale_start_end_dates and sale_rental to v12

0bcecbf

Convert readme to new subdir format

alexis-via and others added 14 commits January 3, 2023 18:38

sale_rental: black, isort, etc.

129d303

[UPD] Update sale_rental.pot

6ce5698

[UPD] README.rst

bc0a12b

[MIG] sale_rental: Migration to 15.0

b226bdc

Standard migration + add some tests

[IMP] : black, isort, prettier, pylint

2298704

[UPD] Update sale_rental.pot

9dad45d

[UPD] README.rst

71d99ed

sale_rental 15.0.1.0.1

bcc5160

[UPD] README.rst

42426c5

[UPD] README.rst

72bbf88

Translated using Weblate (French (France))

60d7ddb

Currently translated at 40.7% (42 of 103 strings) Translation: sale-workflow-15.0/sale-workflow-15.0-sale_rental Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-15-0/sale-workflow-15-0-sale_rental/fr_FR/

Translated using Weblate (French (France))

11962f0

Currently translated at 63.1% (65 of 103 strings) Translation: sale-workflow-15.0/sale-workflow-15.0-sale_rental Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-15-0/sale-workflow-15-0-sale_rental/fr_FR/

Translated using Weblate (French)

33df2c1

Currently translated at 49.5% (51 of 103 strings) Translation: sale-workflow-15.0/sale-workflow-15.0-sale_rental Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-15-0/sale-workflow-15-0-sale_rental/fr/

[16.0][MIG] sale_rental

438366b

OCA-git-bot added this to the 16.0 milestone Jan 26, 2023

OCA-git-bot mentioned this pull request Jan 26, 2023

Migration to version 16.0 #2215

Open

rousseldenis added needs review migration labels Jan 26, 2023

Kev-Roche suggested changes Dec 14, 2023

View reviewed changes

This was referenced Dec 14, 2023

[16.0][ADD] rental_variant OCA/vertical-rental#36

Open

[16.0][ADD] rental_lot OCA/vertical-rental#37

Open

coffeinisfun mentioned this pull request Feb 26, 2024

[16.0][ADD] sale_rental OCA/vertical-rental#45

Closed

pedrobaeza closed this Feb 28, 2024

coffeinisfun mentioned this pull request Mar 6, 2024

[16.0][ADD] sale_rental OCA/vertical-rental#46

Open

This was referenced Nov 27, 2024

[16.0][MIG] sale_rental: Migration to 16.0 #3366

Open

[17.0][MIG] sale_rental #3435

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[16.0][MIG] sale_rental #2325

[16.0][MIG] sale_rental #2325

Murtaza-OSI commented Jan 3, 2023

chandni299 commented Jan 5, 2023

rousseldenis commented Jan 26, 2023

pedrobaeza commented Aug 14, 2023

Kev-Roche left a comment

Kev-Roche Dec 14, 2023

Kev-Roche Dec 14, 2023

Kev-Roche Dec 14, 2023

coffeinisfun commented Feb 28, 2024

	self.assertEqual(sol.price_subtotal, 60)
	self.assertEqual(sol.price_subtotal, 600)

[16.0][MIG] sale_rental #2325

[16.0][MIG] sale_rental #2325

Conversation

Murtaza-OSI commented Jan 3, 2023

chandni299 commented Jan 5, 2023

rousseldenis commented Jan 26, 2023

pedrobaeza commented Aug 14, 2023

Kev-Roche left a comment

Choose a reason for hiding this comment

Kev-Roche Dec 14, 2023

Choose a reason for hiding this comment

Kev-Roche Dec 14, 2023

Choose a reason for hiding this comment

Kev-Roche Dec 14, 2023

Choose a reason for hiding this comment

coffeinisfun commented Feb 28, 2024