-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
handle oai response with workspace clone #581
handle oai response with workspace clone #581
Conversation
Codecov Report
@@ Coverage Diff @@
## master #581 +/- ##
==========================================
+ Coverage 84.60% 84.71% +0.10%
==========================================
Files 49 49
Lines 2813 2845 +32
Branches 550 554 +4
==========================================
+ Hits 2380 2410 +30
- Misses 332 333 +1
- Partials 101 102 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you very much. I like how concisely you implemented this and I've learned about pytest/unittest features I haven't used yet but will in the future.
I have refactored a few things and from my POV this can be merged.
However, I would really like to see some tests with real-world OAI-PMH endpoints to make sure the solution is robust enough. @wrznr @mikegerber can you try this and give short feedback whether this PR fits your use case?
I've tested this with a few samples provided by @wrznr @maria-federbusch and @cneud from OAI-PMH endpoints at @slub and @StaatsBibliothekBerlin and they all work flawlessly |
Sorry for not replying earlier: It's working fine 👍 (The METS needs more massaging after that, i.e. #544, but that's a different issue.) |
New Feature to enable workspace creation from OAI-Responses.
See #539 for details.