Merge pull request #55 from OCTRI/reddev-539-perm-fix

REDDEV-539 removed check for module access

README.md

@@ -10,3 +10,15 @@ in a time series fashion to provide additional insights about their project.
 # Vizr Installation and Upgrades
 
 See [INSTALL.md](INSTALL.md).
+
+# Vizr Permissions
+
+All users of a project with Vizr enabled may view charts.
+
+For users that also need to create, edit, and delete charts you must give them **Project Design and Setup** rights. To do so follow these steps:
+
+* Navigate, on a project with Vizr, to **User Rights**
+* Select a user
+* Click **Edit user privileges**
+* Under **Highest level privileges** check **Project Design and Setup*
+* Save

Vizr.php

@@ -7,21 +7,16 @@
 class Vizr extends AbstractExternalModule {
 
   /**
-   * Override to check for Vizr User Rights. Else returns the parent value
-   * which checks for design rights.
+   * Override to allow anyone with project access to be able to view Vizr charts. The
+   * user will need `Project Design and Setup` rights in order to create, edit, and
+   * delete charts.
    */
   public function redcap_module_link_check_display($project_id, $link) {
-    $rights = \REDCap::getUserRights(USERID);
-    if ($this->hasVizrUserRights($rights)) {
-      return $link;
-    } else {
-      return parent::redcap_module_link_check_display($project_id, $link);
-    }
+    return $link;
   }
 
   /**
-   * Checks to see if a user has user rights for the Vizr external module on
-   * the current project.
+   * Checks to see if a user has module rights for Vizr on the current project.
    * @param array $rights Array of user rights from <code>REDCap::getUserRights</code>.
    */
   public function hasVizrUserRights($rights) {
@@ -39,12 +34,12 @@ public function hasDesignRights($rights) {
   }
 
   /**
-   * Checks to see if the user can edit charts. A user can edit charts if they
-   * are a super user or have design or user rights for the vizr module.
+   * Checks to see if the user can edit charts in Vizr. A user can edit charts if they
+   * are a super user or have design rights.
    */
   public function canEditVizrCharts() {
     $rights = \REDCap::getUserRights(USERID);
-    return SUPER_USER || $this->hasDesignRights($rights) || $this->hasVizrUserRights($rights);
+    return SUPER_USER || $this->hasDesignRights($rights);
   }
 
 }

config.json

@@ -41,13 +41,6 @@
   "permissions": [
     "select_data"
   ],
-  "project-settings": [
-    {
-      "key": "vizr-descriptive",
-      "name": "To configure a chart, click the Vizr link under <strong>External Modules</strong> on the left navigation bar. On that page there's a link titled \"Vizr charts are configured\" which contains documentation for building charts.",
-      "type": "descriptive"
-    }
-  ],
   "links": {
     "project": [
       {