Skip to content

Commit

Permalink
Fix dependencies and dune utop (#1292)
Browse files Browse the repository at this point in the history
- The camlzip is not a dependency of `alt-ergo-lib` but the alt-ergo
  binary.
- Menhir is no longer a dependency, as the legacy frontend has been
  removed.
- `dune utop` failed for two reasons:
  1. camlzip is not compatible with the toplevel.
  2. js_of_ocaml library contains toplevel expressions whose the
     evaluation requires a JavaScript runtime.
  After this PR, `dune utop src/lib` works as expected.
  • Loading branch information
Halbaroth authored Feb 11, 2025
1 parent 465a4b2 commit 837293e
Show file tree
Hide file tree
Showing 6 changed files with 4 additions and 5 deletions.
1 change: 0 additions & 1 deletion alt-ergo-lib.opam
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ depends: [
"stdlib-shims"
"ppx_blob" {>= "0.7.2"}
"ppx_deriving"
"camlzip" {>= "1.07"}
"odoc" {with-doc}
"ppx_deriving"
"qcheck" {with-test & = "0.22"}
Expand Down
2 changes: 1 addition & 1 deletion alt-ergo.opam
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,10 @@ depends: [
"ocaml" {>= "4.08.1"}
"dune" {>= "3.14"}
"alt-ergo-lib" {= version}
"menhir"
"dune-site"
"cmdliner" {>= "1.1.0"}
"odoc" {with-doc}
"camlzip" {>= "1.07"}
]
build: [
["dune" "subst"] {dev}
Expand Down
3 changes: 1 addition & 2 deletions dune-project
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,10 @@ See more details on https://alt-ergo.ocamlpro.com/")
(ocaml (>= 4.08.1))
dune
(alt-ergo-lib (= :version))
menhir
dune-site
(cmdliner (>= 1.1.0))
(odoc :with-doc)
(camlzip (>= 1.07))
)

(sites (share preludes) (lib plugins))
Expand Down Expand Up @@ -63,7 +63,6 @@ See more details on http://alt-ergo.ocamlpro.com/"
stdlib-shims
(ppx_blob (>= 0.7.2))
ppx_deriving
(camlzip (>= 1.07))
(odoc :with-doc)
ppx_deriving
(qcheck (and :with-test (= 0.22)))
Expand Down
1 change: 1 addition & 0 deletions shell.nix
Original file line number Diff line number Diff line change
Expand Up @@ -42,5 +42,6 @@ pkgs.mkShell {
landmarks
landmarks-ppx
qcheck
utop
];
}
1 change: 1 addition & 0 deletions src/bin/common/dune
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
cmdliner
dune-site
dune-site.plugins
camlzip
)
(modules
Config
Expand Down
1 change: 0 additions & 1 deletion src/lib/dune
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
dynlink
ocplib-simplex
stdlib-shims
camlzip
dolmen
dolmen_type
dolmen_loop
Expand Down

0 comments on commit 837293e

Please sign in to comment.