Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change to a prettier font #28

Merged
merged 4 commits into from
Feb 25, 2024
Merged

Change to a prettier font #28

merged 4 commits into from
Feb 25, 2024

Conversation

sercero
Copy link
Contributor

@sercero sercero commented Feb 24, 2024

No description provided.

@paroj
Copy link
Member

paroj commented Feb 24, 2024

"prettier" is of course quite subjective. However when changing the Font the following should be considered:

  • use imgui_overlay.addFont, so Ogre can increase the font resolution according to the pixel_ratio
  • use a monospace font for the log, as some outputs rely on that to be aligned

ogre_mesh_viewer.py Outdated Show resolved Hide resolved
Liberation.fontdef Outdated Show resolved Hide resolved
@paroj
Copy link
Member

paroj commented Feb 25, 2024

can you rebase on master, so the test is run?

@sercero
Copy link
Contributor Author

sercero commented Feb 25, 2024

can you rebase on master, so the test is run?

I did...
The test did run

@paroj
Copy link
Member

paroj commented Feb 25, 2024

woops.. did not notice that. However it actually crashes:
https://github.com/OGRECave/ogre-meshviewer/actions/runs/8038772015/job/21955059980#step:4:270

seems I did not properly propagate the return value..

@sercero
Copy link
Contributor Author

sercero commented Feb 25, 2024

woops.. did not notice that. However it actually crashes: https://github.com/OGRECave/ogre-meshviewer/actions/runs/8038772015/job/21955059980#step:4:270

seems I did not properly propagate the return value..

What would be the best way to add the application or the font directory to a resource group, perhaps using "./fonts" is not the proper way...

@paroj
Copy link
Member

paroj commented Feb 25, 2024

seems I did not properly propagate the return value..

rebase again..

What would be the best way to add the application or the font directory

os.path.dirname(__file__)+"/fonts"

@sercero
Copy link
Contributor Author

sercero commented Feb 25, 2024

seems I did not properly propagate the return value..

rebase again..

Strange... the CI is not running it seems

between the old and the new look
@paroj paroj merged commit 6219af8 into OGRECave:master Feb 25, 2024
1 check passed
@sercero sercero deleted the font_change branch March 3, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants