Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplifying use of ApplicationContext framework #3034

Closed
wants to merge 0 commits into from

Conversation

Joilnen
Copy link
Contributor

@Joilnen Joilnen commented Feb 16, 2024

Proposal
try to avoid internal root exposing to user application as much as possible, no break the actual interface,
changed the Bootstrap.cpp tutorial if it is accept I change the rest

@paroj
Copy link
Member

paroj commented Feb 18, 2024

try to avoid internal root exposing to user application as much as possible

why do you think this is beneficial? The Root object provides access to some important functions like the WorkQueue. Also it is a Singleton, so it is not really hidden..

@paroj paroj marked this pull request as draft February 18, 2024 20:56
@paroj
Copy link
Member

paroj commented Feb 18, 2024

also you accidentally reverted some recent changes in master

@Joilnen
Copy link
Contributor Author

Joilnen commented Feb 19, 2024

also you accidentally reverted some recent changes in master

My intention is avoid to expose root as much as possible, and to leave only ScaneManager as point of interaction with Ogre less failing points, the other features from Root I think to wrap them in ApplicationContext, and made applications created with this framework smaller and easier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants