feat/new customization service fix ss #4688
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… 'inheritsFrom' across multiple files for consistency and clarity - Changed 'customizationType' to 'inheritsFrom' in overlay items and context menus to better reflect inheritance relationships. - Updated related documentation and type definitions to align with the new property name. - Adjusted the CustomizationService to support the new inheritance model. This change enhances the clarity of customization definitions and improves the overall structure of the customization system.
…ation across multiple files - Replaced instances of customizationService.get with customizationService.getCustomization for consistency and clarity. - Adjusted related logic to ensure default values are handled correctly when retrieving customizations. - This change improves the maintainability of the codebase by standardizing the method used for accessing customization properties.
…ocumentation for customization service - Updated the visibility of the `setModeCustomization` method from public to private to encapsulate its functionality within the CustomizationService class. - Improved documentation in the customization-service.md file for better clarity on customization types, modification methods, and usage examples. - Added CSS styles for ordered lists in custom.css to enhance the presentation of documentation. These changes aim to improve code encapsulation, enhance documentation clarity, and ensure better styling in the UI.
- Refactored customization modules in various extensions to use object notation instead of arrays for better clarity and maintainability. - Added DicomUpload component to the cornerstone extension's customization module. - Updated the customization service to accept configuration during initialization. - Enhanced the handling of custom routes and context menus across extensions. - Cleaned up and organized the code for better readability and consistency.
…configuration - Refactored the customization service to streamline the addition of references. - Updated the configuration for the customization service in default.js to use a more structured object notation for overlays, enhancing clarity and maintainability. - Improved the organization of customization modules for better readability.
- Removed the 'merge' property from the helloPage customization. - Commented out the datasources customization to streamline the code. - Updated the customizationService structure in the default configuration for better clarity and maintainability. - Removed redundant comments and cleaned up the CustomizationService type imports.
…handling - Updated the customization module to use `$push` for adding custom routes, improving flexibility. - Reintroduced the 'datasources' customization with the new route structure. - Modified the default configuration to include the new customization module references. - Improved the cloning logic in the CustomizationService for better handling of various data types.
…ation - Added a new customization module for sorting functions in the study browser, allowing users to define custom sort behavior. - Updated the default configuration to include the new customization module reference. - Created new documentation files for context menus, custom routes, and viewport click behavior to enhance user understanding of customization capabilities. - Removed outdated documentation related to the customization service for better clarity and organization.
…nd handling - Updated the customization service to use `getCustomization` for retrieving measurement labels and viewport click commands. - Removed deprecated default configurations for double-click and context menu commands, streamlining the code. - Introduced new images for measurement labels and series sorting in the documentation. - Added comprehensive documentation for the customization service, detailing customizable parts and examples. - Improved the overall structure and clarity of the customization module and its related files.
…ent integration - Added CinePlayer component to the customization module for better integration with the UI. - Updated window level presets to include unique IDs for each preset, improving configurability. - Refactored the handling of customization service in the default configuration, streamlining the setup process. - Introduced new images for window level presets and colorbar in the documentation to enhance visual understanding. - Improved command handling in the CommandsManager to support function-based commands, increasing flexibility. - Updated documentation to reflect new customization capabilities and examples for better user guidance.
- Replaced the existing `getCustomizationModule.ts` file with a new `getCustomizationModule.tsx` file, integrating React components for improved UI handling. - Updated the `PanelSegmentation` component to utilize the new customization structure, simplifying the retrieval of customization options. - Enhanced the `ActiveViewportBehavior` and tool group initialization functions to directly access customization settings, improving code clarity. - Removed deprecated customization configurations and streamlined the customization service for better performance and maintainability. - Added new images and documentation for various customization options, including layout selectors and segmentation features, to improve user guidance and understanding. - Introduced new customization options for auto cine modalities and panel measurement editing behavior, expanding user configurability.
…nt integration - Refactored the context menu initialization to optimize nearby tool data retrieval. - Enhanced the WorkflowPanel component by cleaning up the customization service integration. - Added new customization options for the Study Browser, including study mode and view presets. - Updated the MeasurementTable and MeasurementItem components to streamline customization retrieval. - Introduced new sorting functions for the Study Browser, improving user configurability. - Added documentation for the Study Browser customizations to enhance user understanding.
…configuration - Changed display name from 'Area' to 'Areas' in SplineROI customization. - Simplified the retrieval of PlanarFreehandROI and SplineROI configurations by removing unnecessary default object handling. - Removed deprecated multimonitor layout configurations from default and e2e config files. - Added new customization options for measurement tools in the documentation, enhancing user guidance on available features.
…ve outdated documentation - Added new customization options for viewport overlays, including a PatientNameOverlay for the bottom-left section. - Updated the viewportOverlay documentation to include new customization endpoints and examples. - Removed the outdated viewport click behavior documentation to streamline the customization service resources.
…tion options - Removed unused dropdown menu components from PanelSegmentation, simplifying the code. - Updated the customization service to improve the handling of segmentation-related customizations. - Introduced a new customization option for readable text labels in the segmentation panel, enhancing user clarity. - Added a utility function to check for dollar key presence in customization values, improving data handling. - Updated documentation to reflect new customization capabilities for segmentation statistics and metrics.
…ions - Introduced a new sorting criteria for series in the customization module, improving the organization of displayed data. - Updated the PanelSegmentation configuration to include an option for disabling editing of segmentations, enhancing user control. - Added new images to represent the editing state in the documentation, improving visual guidance for users. - Refactored the DataRow component to conditionally render actions based on the editing state, streamlining user interactions. - Cleaned up imports and removed unused code to improve overall code quality and maintainability.
…e new dropdown menus - Introduced new dropdown menu items for the Study Browser, including a Tag Browser and additional commands for managing study items. - Updated the customization service to support dynamic menu items in the Study Browser, improving user interaction and configurability. - Refactored the PanelStudyBrowser and PanelStudyBrowserTracking components to utilize the new MoreDropdownMenu for better integration. - Removed deprecated customization configurations from the default settings, streamlining the overall configuration process. - Added new images to the documentation for the thumbnail and study menu items, enhancing visual guidance for users.
… menu functionality - Refactored the customization module to improve the handling of multimonitor configurations, ensuring better integration with the Study Browser. - Updated the dropdown menu structure to utilize a more efficient approach for managing menu items, enhancing user interaction. - Added checks for callback functions in the HangingProtocolService to prevent potential errors during protocol transitions. - Modified the default configuration to include the new multimonitor customization service, streamlining setup for users. - Improved code clarity and maintainability by restructuring menu item rendering logic and cleaning up unused code.
…guration options - Updated the DICOM Web API to support both 'StudyInstanceUIDs' and 'studyInstanceUIDs' parameters, improving flexibility in handling study queries. - Introduced new multimonitor configuration options in the default settings, allowing for better screen management and user experience in multi-display setups. - Enhanced the screen layout definitions for multimonitor setups, providing clearer specifications for screen dimensions and positions. - Improved code clarity and maintainability by restructuring the configuration logic and ensuring consistent parameter handling.
…uration structure - Updated the `getCustomizationModule` function to return an array of objects for better clarity and structure in customization settings. - Removed unnecessary properties from `codingValues` to streamline the configuration. - Simplified the customization service initialization in the basic test mode for improved readability. - Enhanced the MeasurementItem component with better hover and click interactions, improving user experience. - Updated the default configuration to utilize an object for the customization service, allowing for more flexible customization options. - Added validation to prevent prototype pollution in the CommandsManager, enhancing security and stability. - Cleaned up unused code and improved overall maintainability across multiple files.
✅ Deploy Preview for ohif-platform-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for ohif-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
…n up context menu items - Updated the `getCustomizationModule` function to return objects instead of arrays for better clarity in customization settings. - Removed unnecessary `id` properties from `contextMenuCodeItem` and `findingsContextMenu` to streamline the configuration. - Enhanced overall maintainability by cleaning up unused code across multiple files.
Viewers
|
||||||||||||||||||||||||||||||||||
| Project |
Viewers
|
| Branch Review |
feat/new-customization-service-fix-ss
|
| Run status |
|
| Run duration | 02m 11s |
| Commit |
|
| Committer | sedghi |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
1
|
Flaky
|
0
|
Pending
|
2
|
Skipped
|
0
|
Passing
|
43
|
| View all changes introduced in this branch ↗︎ | |
Tests for review
cypress/integration/measurement-tracking/OHIFContextMenuCustomization.spec.js • 1 failed test
| Test | Artifacts | |
|---|---|---|
| OHIF Context Menu > checks context menu customization |
Test Replay
Screenshots
Video
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://deploy-preview-4688--ohif-platform-docs.netlify.app/platform/services/customization-service/customizationService