-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dns: adds test for sshfp #1588
dns: adds test for sshfp #1588
Conversation
Current failure :
@jasonish is this normal to have uppercase dns.grouped.SSHFP ? |
Normal I don't know, per our code its expected - all the type names are logged in uppercase in the groupings. |
@hadiqaalamdar your job is to make this SV test pass then ;-) also with |
created the new schema.json PR: OISF/suricata#10401 |
7490af2
to
83699b6
Compare
New schema.json PR: OISF/suricata#10429 |
83699b6
to
21fde01
Compare
Merged in #1663, thanks! |
Ticket
Redmine ticket: https://redmine.openinfosecfoundation.org/issues/5642
Or rather https://redmine.openinfosecfoundation.org/issues/6478
But I think there should be its own subticket for dns
Meant to pass with OISF/suricata#10193