Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

output/plugin: Use Suri thread-id for plugins #10159

Closed
wants to merge 2 commits into from

Conversation

jlucovsky
Copy link
Contributor

Continuation of #9709

Issue: 6408

Use the Suricata thread id for plugin thread initialization to give the plugin a better correlating factor to the actual Suricata threads.

Link to redmine ticket: 6408

Describe changes:

  • Pass the actual thread id to the ThreadInit function instead of the "slot number"

Update:

  • Update example plugin to use ThreadId type
  • Add ThreadId type for plugin interface

Provide values to any of the below to override the defaults.

To use a pull request use a branch name like pr/N where N is the
pull request number.

Alternatively, SV_BRANCH may also be a link to an
OISF/suricata-verify pull-request.

SV_REPO=
SV_BRANCH=
SU_REPO=
SU_BRANCH=
LIBHTP_REPO=
LIBHTP_BRANCH=

Issue: 6408

Use the Suricata thread id for plugin thread initialization to give the
plugin a better correlating factor to the actual Suricata threads.
@jlucovsky jlucovsky requested review from victorjulien and a team as code owners January 14, 2024 14:49
@jlucovsky jlucovsky changed the title Plugin/8 output/plugin: Use Suri thread-id for plugins Jan 14, 2024
Copy link

codecov bot commented Jan 14, 2024

Codecov Report

Attention: 18 lines in your changes are missing coverage. Please review.

Comparison is base (1dcf69b) 82.19% compared to head (16722da) 82.07%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10159      +/-   ##
==========================================
- Coverage   82.19%   82.07%   -0.12%     
==========================================
  Files         974      974              
  Lines      271825   271832       +7     
==========================================
- Hits       223416   223117     -299     
- Misses      48409    48715     +306     
Flag Coverage Δ
fuzzcorpus 62.64% <9.09%> (-0.38%) ⬇️
suricata-verify 61.39% <18.18%> (-0.02%) ⬇️
unittests 62.85% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@suricata-qa
Copy link

Information: QA ran without warnings.

Pipeline 17506

@victorjulien victorjulien requested review from jasonish and removed request for a team and victorjulien January 19, 2024 11:35
@jasonish
Copy link
Member

jasonish commented Mar 7, 2024

@jlucovsky Can you rebase? Was there anything else that needed to be resolved here? I'm keen to get this documented.

@jlucovsky
Copy link
Contributor Author

Merged with #10636 in #10652

@jlucovsky jlucovsky closed this Mar 19, 2024
@jlucovsky jlucovsky deleted the plugin/8 branch March 19, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants