dns: add missing dns keywords to schema.json #10193
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1083,6 +1083,21 @@ | |
| } | ||
| }, | ||
| "additionalProperties": false | ||
| }, | ||
| "sshfp": { | ||
| "type": "object", | ||
| "properties": { | ||
| "fingerprint": { | ||
| "type": "string" | ||
| }, | ||
| "algo": { | ||
| "type": "integer" | ||
| }, | ||
| "type": { | ||
| "type": "string" | ||
| } | ||
| }, | ||
| "additionalProperties": false | ||
| } | ||
| }, | ||
| "additionalProperties": false | ||
|
|
@@ -1156,6 +1171,15 @@ | |
| "opcode": { | ||
| "description": "DNS opcode as an integer", | ||
| "type": "integer" | ||
| }, | ||
| "aa": { | ||
| "type": "boolean" | ||
| }, | ||
| "tc": { | ||
| "type": "boolean" | ||
| }, | ||
| "z": { | ||
| "type": "boolean" | ||
|
There was a problem hiding this comment. z is already present as well. @jasonish do you know how to test in CI for duplicate keys in this schema.json ? There was a problem hiding this comment. Extract the code out of check-eve.py back into a standalone script could be one option. There was a problem hiding this comment. There was a problem hiding this comment. Adding things to the schema in alphabetic order could also be useful for catching this on review. There was a problem hiding this comment. I think the first version of the schema had all key alphabetically order, but that was a pain, and I did not know how to enforce it (or even if it should be enforced) There was a problem hiding this comment. Once done, its easy to keep done right? Then its pretty obvious. I think you can only enforce with review though, or doing a custom JSON parser of sorts, as most throw order out. There was a problem hiding this comment.
Does not look easy to me...
Automation looks more trustworthy to me There was a problem hiding this comment.
Ok. Out of scope for this PR tho. There was a problem hiding this comment.
Sure cf https://redmine.openinfosecfoundation.org/issues/6691 |
||
| } | ||
| }, | ||
| "additionalProperties": false | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jasonish should we add description for these added fields ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
aais already present !There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, will help with documentation generation.