detect: flush when setting no_inspection #10540
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ticket: 6578 When a protocol such as SSH sets no_inspection, we still have to flush the current streams and packets that contain clear-text for detection.
|
WARNING:
Pipeline 18865 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #10540 +/- ##
==========================================
- Coverage 82.65% 82.64% -0.02%
==========================================
Files 921 921
Lines 246857 246864 +7
==========================================
- Hits 204049 204020 -29
- Misses 42808 42844 +36
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
WARNING:
Pipeline 19252 |
|
It is expected to have more pseudo packets as this PR creates more as required. So, this will require a QA rebaseline... |
victorjulien
approved these changes
Mar 18, 2024
Merged
|
Merged in #10657, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/6578
Describe changes:
So that we can run detection on the clear text of ssh new keys packet
SV_BRANCH=OISF/suricata-verify#1639
#10192 just rebased