next/326/20240302/v1 #10552
Merged
next/326/20240302/v1 #10552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move the zero'ing to the thread module array InitGlobal in an effort to fix capture modules. At some point device validation moved to a point in startup before plugins are loaded meaning that capture plugins could not be used. Moving plugin registration early enough caused some of their registration to be wiped out as clearing the array was done after. Bug: OISF#6811
Capture plugins need to be registered before LiveDeviceFinalize, otherwise Suricata errors before the plugin gets a chance to load. Bug: OISF#6811
Create a mininal capture plugin that injects one packet. While it can also be a template, we should be able to run this in CI to test the loading and registration of the capture plugin mechanisms.
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.24.5 to 3.24.6. - [Release notes](https://github.com/github/codeql-action/releases) - [Commits](github/codeql-action@v3.24.5...v3.24.6) --- updated-dependencies: - dependency-name: github/codeql-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [actions/download-artifact](https://github.com/actions/download-artifact) from 4.1.3 to 4.1.4. - [Release notes](https://github.com/actions/download-artifact/releases) - [Commits](actions/download-artifact@87c5514...c850b93) --- updated-dependencies: - dependency-name: actions/download-artifact dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #10552 +/- ##
==========================================
+ Coverage 78.40% 82.67% +4.26%
==========================================
Files 922 922
Lines 246779 246969 +190
==========================================
+ Hits 193488 204179 +10691
+ Misses 53291 42790 -10501
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Information: QA ran without warnings. Pipeline 18932 |
jasonish
approved these changes
Mar 3, 2024
This was referenced Mar 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Staging: