ARP: implement decoder and logger #10570
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glongo
requested review from
jufajardini,
victorjulien and
a team
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #10570 +/- ##
========================================
Coverage 82.67% 82.67%
========================================
Files 922 924 +2
Lines 246969 247149 +180
========================================
+ Hits 204179 204332 +153
- Misses 42790 42817 +27
Flags with carried forward coverage won't be shown. Click here to find out more. |
jlucovsky
reviewed
Mar 4, 2024
| @@ -0,0 +1,256 @@ | |||
| /* Copyright (C) 2021 Open Information Security Foundation | |||
| return "pure_ip"; | ||
| case 36: | ||
| return "hw_exp1"; | ||
| case 37: |
There was a problem hiding this comment.
https://www.iana.org/assignments/arp-parameters/arp-parameters.xhtml
38 has a value as do 256 and 257.
|
|
||
| static bool JsonArpLogCondition(ThreadVars *tv, void *thread_data, const Packet *p) | ||
| { | ||
| if (!PKT_IS_ARP(p)) { |
There was a problem hiding this comment.
nit: suggest return PKT_IS_ARP(p)
| @@ -0,0 +1,28 @@ | |||
| /* Copyright (C) 2021 Open Information Security Foundation | |||
|
Replaced with #10572 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure these boxes are signed before submitting your Pull Request -- thank you.
https://docs.suricata.io/en/latest/devguide/contributing/contribution-process.html
https://suricata.io/about/contribution-agreement/ (note: this is only required once)
Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/6827
Describe changes:
JSONFormatAndAddMACAddrpublicSV_BRANCH=OISF/suricata-verify#1681