flow: Add cfg for optional flow reuse during low memory #10580
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default, force flow reuse to reuse an existing flows no matter the state of the flow. Add a configuration option flow.force-reuse, enabled by default, that can turn off the above behaviour. Ticket: OISF#6293
coledishington
requested review from
jufajardini,
victorjulien and
a team
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #10580 +/- ##
==========================================
+ Coverage 82.74% 82.78% +0.04%
==========================================
Files 924 924
Lines 247401 247410 +9
==========================================
+ Hits 204719 204826 +107
+ Misses 42682 42584 -98
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Replaced by #10585 to trigger re-test of new suricata-verify changes in OISF/suricata-verify#1688. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, force flow reuse to reuse an existing flows no matter the state of the flow.
Add a configuration option flow.force-reuse, enabled by default, that can turn off the above behavior.
Ticket: #6293
Make sure these boxes are signed before submitting your Pull Request -- thank you.
https://docs.suricata.io/en/latest/devguide/contributing/contribution-process.html
https://suricata.io/about/contribution-agreement/ (note: this is only required once)
Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/6293
Describe changes:
Add a configuration option flow.force-reuse, enabled by default, that can turn off flow reuse in low memory situations.
Provide values to any of the below to override the defaults.