Bug/6790 add worker sync on finish v3 #10628
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 12, 2024 23:25
When Suricata was running in IPS mode and received a signal to stop, the first worker of every interface/port stopped the port and proactively stopped the peered interface as well. This was done to be as accurate with port stats as possible. However, in a highly active scenarios (lots of packets moving around) the peered workers might still be in the process of a packet release operation. These workers would then attempt to transmit on a stopped interface - resulting in an errorneous operation. Instead, this patch proposes a worker synchronization of the given port. After these workers are synchronized, it is known that no packets will be sent of the peered interface, therefore the first worker can stop it. This however cannot be assumed about "its own" port as the peered workers can still try to send the packets. Therefore, ports are only stopped by the peered workers. Ticket: OISF#6790
| static void DPDKSegmentedMbufWarning(struct rte_mbuf *mbuf) | ||
| { | ||
| static bool segmented_mbufs_warned = false; | ||
| if (!rte_pktmbuf_is_contiguous(mbuf) && !segmented_mbufs_warned) { |
There was a problem hiding this comment.
how expensive is rte_pktmbuf_is_contiguous? May be cheaper to check segmented_mbufs_warned first?
| pwd_zero_rx_packet_polls_count++; | ||
| if (pwd_zero_rx_packet_polls_count <= MIN_ZERO_POLL_COUNT) | ||
| continue; | ||
| static void DPDKSegmentedMbufWarning(struct rte_mbuf *mbuf) |
There was a problem hiding this comment.
inline? Runs for each pkt I think
| * \brief Initializes a packet from an mbuf | ||
| * \return true if the packet was initialized successfully, false otherwise | ||
| */ | ||
| static bool PacketInitFromMbuf(DPDKThreadVars *ptv, struct rte_mbuf *mbuf, Packet **pkt_out) |
victorjulien
requested changes
Mar 13, 2024
|
Information: QA ran without warnings. Pipeline 19303 |
|
I inlined your comments, let's continue in #10642 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up of: #10564
Ticket: #6790
https://redmine.openinfosecfoundation.org/issues/6790
Describe changes:
v3
v2
v1