Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output alert applayer v25 #10631

Closed

Conversation

catenacyber
Copy link
Contributor

Link to redmine tickets:
https://redmine.openinfosecfoundation.org/issues/3827
Preliminary work for https://redmine.openinfosecfoundation.org/issues/5053

Describe changes:

  • output: unify boilerplate code (trying to become a lines-of-code neutral contributor to Suricata ;-) and rising the percentage of rust files )
  • output/dns: do not add empty app-layer metadata
  • dnp3: restrict function scope to one file

#10548 with needed rebase after header files changes, still removed

Copy link

codecov bot commented Mar 13, 2024

Codecov Report

Attention: Patch coverage is 98.26087% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 82.70%. Comparing base (59d18b9) to head (6019357).

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10631      +/-   ##
==========================================
- Coverage   82.75%   82.70%   -0.05%     
==========================================
  Files         925      913      -12     
  Lines      247551   247203     -348     
==========================================
- Hits       204852   204459     -393     
- Misses      42699    42744      +45     
Flag Coverage Δ
fuzzcorpus 64.07% <81.73%> (+0.02%) ⬆️
suricata-verify 61.87% <98.26%> (-0.03%) ⬇️
unittests 62.29% <41.73%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@suricata-qa
Copy link

Information:

ERROR: QA failed on SURI_TLPW2_autofp_suri_time.

ERROR: QA failed on SURI_TLPR1_suri_time.

field baseline test %
SURI_TLPW2_autofp_stats_chk
.uptime 138 148 107.25%
SURI_TLPR1_stats_chk
.uptime 638 680 106.58%

Pipeline 19297

@catenacyber
Copy link
Contributor Author

Rebased in #10680

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants