Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

napatech: emit HBA deprecation only once #10644

Merged
merged 1 commit into from
Mar 15, 2024

Conversation

jlucovsky
Copy link
Contributor

Continuation of #9478

Issue: 6313
This commit removes duplicate HBA deprecation messages from being emitted.

Make sure these boxes are signed before submitting your Pull Request -- thank you.

Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/6313

Describe changes:

  • This commit removes duplicate HBA deprecation messages from being emitted.

Updates:

  • Rebuilt PR as previous was performing commit check against master instead of main-7.0.x

Provide values to any of the below to override the defaults.

To use a pull request use a branch name like pr/N where N is the
pull request number.

Alternatively, SV_BRANCH may also be a link to an
OISF/suricata-verify pull-request.

SV_REPO=
SV_BRANCH=
SU_REPO=
SU_BRANCH=
LIBHTP_REPO=
LIBHTP_BRANCH=

Issue: 6313
This commit removes duplicate HBA deprecation messages from being
emitted.
Copy link

NOTE: This PR may contain new authors.

Copy link

codecov bot commented Mar 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.27%. Comparing base (8e8efd2) to head (05640d8).

Additional details and impacted files
@@              Coverage Diff               @@
##           main-7.0.x   #10644      +/-   ##
==============================================
- Coverage       82.39%   82.27%   -0.13%     
==============================================
  Files             976      976              
  Lines          275035   275035              
==============================================
- Hits           226616   226276     -340     
- Misses          48419    48759     +340     
Flag Coverage Δ
fuzzcorpus 62.78% <ø> (-0.70%) ⬇️
suricata-verify 61.63% <ø> (+0.01%) ⬆️
unittests 62.91% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@suricata-qa
Copy link

Information: QA ran without warnings.

Pipeline 19340

@victorjulien victorjulien merged commit 05640d8 into OISF:main-7.0.x Mar 15, 2024
122 of 127 checks passed
@victorjulien
Copy link
Member

Merged in #10648, thanks!

@jlucovsky jlucovsky deleted the 6313/1 branch March 17, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants