Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flow: Use proper thread id for injection #10650

Closed
wants to merge 3 commits into from
Closed

Conversation

jlucovsky
Copy link
Contributor

Continuation of #10643

Link to redmine ticket: 6835

Describe changes:

  • Also swap thread_ids when reversing a flow's direction
  • Never choose an uninitialized thread_id during injection
  • Typo fix

Updates:

  • Updated commit comment to mention issue 2725 may be addressed.

Provide values to any of the below to override the defaults.

To use a pull request use a branch name like pr/N where N is the
pull request number.

Alternatively, SV_BRANCH may also be a link to an
OISF/suricata-verify pull-request.

SV_REPO=
SV_BRANCH=
SU_REPO=
SU_BRANCH=
LIBHTP_REPO=
LIBHTP_BRANCH=

Issue: 6835

When injecting a flow, ensure that the selected thread_id has been
initialized. When a flow is picked up midstream, the initialized thread
can be the second thread element.
Issue: 6835

When swapping the flow's direction, also swap the thread_ids.

This should help with the issues identified in
https://redmine.openinfosecfoundation.org/issues/2725
@victorjulien victorjulien added this to the 8.0 milestone Mar 15, 2024
@suricata-qa
Copy link

Information:

ERROR: QA failed on SURI_TLPR1_suri_time.

field baseline test %
SURI_TLPR1_stats_chk
.uptime 638 685 107.37%

Pipeline 19371

@victorjulien
Copy link
Member

Merged in #10652, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants