Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

detect/transform: from_base64 transform #10651

Closed
wants to merge 5 commits into from
Closed

Conversation

jlucovsky
Copy link
Contributor

Continuation of #10561

This PR provides the from_base64 transform used to match on content decoded with base64 using the mode (default rfc4648).

Link to redmine ticket: 6487

Describe changes:

  • New transform: from_base64
  • Documentation
  • Keyword parser in rust.

Updates:

  • Address review comments, including adding the SC prefix for some items exported to C

Provide values to any of the below to override the defaults.

To use a pull request use a branch name like pr/N where N is the
pull request number.

Alternatively, SV_BRANCH may also be a link to an
OISF/suricata-verify pull-request.

SV_REPO=
SV_BRANCH=pr/1670
SU_REPO=
SU_BRANCH=
LIBHTP_REPO=
LIBHTP_BRANCH=

Refactor utility functions/definitions from the byte_math module into
the parser module. This includes parse_var and ResultValue

Issue: 6487
Issue: 6487

Implement from_base64 option parsing in Rust. The Rust module also
contains unit tests.
Issue: 6487

Implement the from_base64 transform:
    [bytes value] [offset value] [mode strict|rfc4648|rfc2045]

    The value for bytes and offset may be a byte_ variable or an
    unsigned integer.
@suricata-qa
Copy link

Information: QA ran without warnings.

Pipeline 19376

Copy link
Contributor

@catenacyber catenacyber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you rebase to get green CI ? And see also my other comment...

@jlucovsky
Copy link
Contributor Author

Continued in #10689

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants