rust: fix build with MSRV #10673
Closed
rust: fix build with MSRV #10673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ticket: 6876 Do not backport try_string_from_bytes as it uses try_reserve And just use string_from_bytes instead Fixes: b9963b3 ("ssh: limit length for banner logs")
catenacyber
force-pushed
the
rust-msrv-6876-v1
branch
from
410ff45 to
dbc1ba9
Compare
|
Is there any practical effect from this change? |
|
Rust panics on allocation failure |
|
Information: QA ran without warnings. Pipeline 19636 |
|
The original commit created In master So, this PR looks like the good way to backport the original commit |
jasonish
approved these changes
Mar 20, 2024
victorjulien
approved these changes
Mar 20, 2024
|
Merged in #10679, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/6876
Describe changes: