Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rust unneeded mut tx v1 #12409

Closed
wants to merge 2 commits into from

Conversation

catenacyber
Copy link
Contributor

Link to ticket: https://redmine.openinfosecfoundation.org/issues/
None, simple cleanup

Describe changes:

  • rust: remove some unneeded mut

Loggers do not change transactions, they read only.
Detection does not change transactions, it reads only.
Copy link

codecov bot commented Jan 16, 2025

Codecov Report

Attention: Patch coverage is 87.50000% with 10 lines in your changes missing coverage. Please review.

Project coverage is 80.62%. Comparing base (078c646) to head (6a19786).
Report is 12 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #12409      +/-   ##
==========================================
- Coverage   80.63%   80.62%   -0.01%     
==========================================
  Files         917      917              
  Lines      258687   258675      -12     
==========================================
- Hits       208601   208568      -33     
- Misses      50086    50107      +21     
Flag Coverage Δ
fuzzcorpus 56.81% <63.46%> (-0.01%) ⬇️
livemode 19.39% <0.00%> (+<0.01%) ⬆️
pcap 44.26% <23.07%> (+<0.01%) ⬆️
suricata-verify 63.25% <87.50%> (+0.02%) ⬆️
unittests 58.51% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@jasonish jasonish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK to me. Using &mut in these places might have been a requirement in a much earlier version of Rust when we established this pattern.

@suricata-qa
Copy link

Information: QA ran without warnings.

Pipeline 24237

@victorjulien victorjulien added this to the 8.0 milestone Jan 16, 2025
@victorjulien
Copy link
Member

Merged in #12413, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants