Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

next/693/20250117/v1 #12424

Merged
merged 5 commits into from
Jan 18, 2025
Merged

next/693/20250117/v1 #12424

merged 5 commits into from
Jan 18, 2025

Conversation

victorjulien
Copy link
Member

catenacyber and others added 5 commits January 17, 2025 16:12
@catenacyber
http: aliases for htp opaque htp_tx_t
23050d7 
In preparation of libhtp rust
@jasonish @victorjulien
rust/flow: move flow support to its own file (cleanup)
7ef4caf 
Move the Rust Flow support from core.rs to flow.rs.
@jasonish @victorjulien
rust/direction: move direction to own file (cleanup)
f62be37 
Move the implementation of Direction to its own file, direction.rs.
@jasonish @victorjulien
rust/log: move rust log and debug utils to debug module
2bcc66d 
Move Rust logging, and debug_validation to a debug module to mirrow
the C side.
@jasonish @victorjulien
rust/detect: remove nested unsafe around keyword registration
c207cfc 
Just a cleanup, I'm not sure why Rust wasn't warning on these
nested/unneeded unsafe's.
@codecov Codecov
Copy link

codecov bot commented Jan 18, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 80.12048% with 99 lines in your changes missing coverage. Please review.

Project coverage is 80.62%. Comparing base (8f6795d) to head (c207cfc).
Report is 5 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #12424      +/-   ##
==========================================
- Coverage   80.63%   80.62%   -0.02%     
==========================================
  Files         918      920       +2     
  Lines      258696   258697       +1     
==========================================
- Hits       208598   208566      -32     
- Misses      50098    50131      +33
Flag Coverage Δ
fuzzcorpus 56.81% <71.70%> (-0.01%) ⬇️
livemode 19.39% <7.31%> (-0.01%) ⬇️
pcap 44.25% <58.29%> (-0.06%) ⬇️
suricata-verify 63.24% <72.81%> (+0.01%) ⬆️
unittests 58.51% <42.82%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@suricata-qa
Copy link

WARNING:

field baseline test %
SURI_TLPR1_stats_chk
.uptime 638 658 103.13%

Pipeline 24258

@suricata-qa
Copy link

Information: QA ran without warnings.

Pipeline 24261

jasonish
jasonish approved these changes Jan 18, 2025
View reviewed changes
Copy link
Member

@jasonish jasonish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Staging looks OK.

@victorjulien victorjulien merged commit c207cfc into OISF:master Jan 18, 2025
60 checks passed
This was referenced Jan 18, 2025
Merged
Closed
@victorjulien victorjulien deleted the next/693/20250117/v1 branch January 18, 2025 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonish jasonish jasonish approved these changes

@jufajardini jufajardini Awaiting requested review from jufajardini jufajardini is a code owner

@catenacyber catenacyber Awaiting requested review from catenacyber catenacyber is a code owner

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@victorjulien @suricata-qa @jasonish @catenacyber