rust: name and visibility cleanups - v3 #12443
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a function is extern "C" and not pub, remove no_mangle so its not exposed as-is into the global name space. Ticket: 7498
Both the macros export_tx_data_get and export_state_data_get can generate non-pub functions as the function they generate is only used as a pointer during registration. Remove "pub" and "no_mangle" from the generated functions and update the names of the generated functions to follow Rust rules as they are no longer exported into the global C namespace. Ticket: 7498
- remove "rs_" prefix from functions that are not exported - prefix exported functions with "SC" - don't export functions that are only used by pointer Ticket: 7498
Remove pub and no_mangle from non-exported functions and rename to Rust style as needed. Ticket: 7498
Remove pub and no_mangle from non-exported functions and rename to Rust as-needed. Ticket: 7498
Remove pub and no_mangle from non-exported functions and rename to Rust as-needed. Ticket: 7498
jasonish
requested review from
jufajardini,
victorjulien and
catenacyber
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #12443 +/- ##
=======================================
Coverage 80.63% 80.64%
=======================================
Files 920 920
Lines 258704 258739 +35
=======================================
+ Hits 208595 208648 +53
+ Misses 50109 50091 -18
Flags with carried forward coverage won't be shown. Click here to find out more. |
victorjulien
approved these changes
Jan 21, 2025
|
Information: QA ran without warnings. Pipeline 24298 |
Merged
|
Merged in #12445, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebase of #12434 with conflicts resolved.