Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

detect/integers: add support for negated strings when enum is used - v3 #12484

Closed

Conversation

AkakiAlice
Copy link
Contributor

@AkakiAlice AkakiAlice commented Jan 27, 2025

Ticket: #7513

Contribution style:

Our Contribution agreements:

Changes (if applicable):

Link to ticket: https://redmine.openinfosecfoundation.org/issues/7513

uint.rs changes:

  • add comment and simpler syntax: line 68

integer-keywords.rst changes:

  • document the usage of negated strings when using enum: line 58, line 66

SV_BRANCH=OISF/suricata-verify#2257
Previous PR = #12453

function detect_parse_uint_enum can parse strings like !bind_request

Ticket: OISF#7513
Copy link

codecov bot commented Jan 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.54%. Comparing base (d63ad75) to head (3613946).
Report is 41 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #12484      +/-   ##
==========================================
+ Coverage   80.52%   80.54%   +0.01%     
==========================================
  Files         923      923              
  Lines      259176   259182       +6     
==========================================
+ Hits       208708   208764      +56     
+ Misses      50468    50418      -50     
Flag Coverage Δ
fuzzcorpus 56.15% <80.00%> (+0.09%) ⬆️
livemode 19.38% <0.00%> (-0.04%) ⬇️
pcap 44.20% <0.00%> (+<0.01%) ⬆️
suricata-verify 63.32% <100.00%> (-0.01%) ⬇️
unittests 58.44% <80.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@catenacyber catenacyber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work :-)
This PR is good, but will be blocked until the SV PR is good as well

CI : 🟢
Code : good
Commits segmentation : ok
Commit messages : good
Git ID set : looks fine for me
CLA : you already contributed
Doc update : thanks for adding
Redmine ticket : ok
Rustfmt : good :-)
Tests : ⚠️ need some improvement on the SV PR
Dependencies added: none

@victorjulien victorjulien added this to the 8.0 milestone Jan 28, 2025
@victorjulien
Copy link
Member

FYI merge is blocked by the SV test not being ready.

@AkakiAlice
Copy link
Contributor Author

Replaced by: #12516

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants