Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ui] [refactor] Drop MemberProfile #4100

Open
benfurber opened this issue Jan 22, 2025 · 5 comments · May be fixed by #4108
Open

[ui] [refactor] Drop MemberProfile #4100

benfurber opened this issue Jan 22, 2025 · 5 comments · May be fixed by #4108

Comments

@benfurber
Copy link
Member

Component infos

Description

We have MemberProfile for users who are the profileType of 'member' and SpaceProfile for other profileTypes. The design of MemberProfile can be dropped and SpaceProfile updated to allow for members. Thus then there's one Profile template. (Basically it's just the header area that should be different and the member badge.)

Page related

Will be used on profiles.

  • Related page name (#issue-number)

Mockup

Image Image

Example(s)

If you have any examples of existing similar components, add the link here. It can be a link to a code snippet and/or to a page of a projet/website where we can interact with the similar component.

Build suggestion

Could create some annoying merge conflicts if done at the same time as #4098 - this should probably be done before or after.

@CrowsVeldt
Copy link
Contributor

I'd like to give this a try

@CrowsVeldt
Copy link
Contributor

Hey, @benfurber. Should I pass the ProfileType down from UserProfile as a prop? Could I just get it from the user object itself?

Image

@CrowsVeldt CrowsVeldt mentioned this issue Jan 24, 2025
12 tasks
@CrowsVeldt
Copy link
Contributor

I can't seem to run cypress locally anymore. I get a SupaBase error.

@CrowsVeldt CrowsVeldt mentioned this issue Jan 25, 2025
12 tasks
@mariojsnunes
Copy link
Contributor

I can't seem to run cypress locally anymore. I get a SupaBase error.

@CrowsVeldt you are probably missing the supabase setup:
https://github.com/ONEARMY/community-platform/blob/master/docs/supabase.md#getting-started

@CrowsVeldt
Copy link
Contributor

@mariojsnunes Thank you!

@CrowsVeldt CrowsVeldt linked a pull request Jan 26, 2025 that will close this issue
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment