Add support for force vsock on firecracker pilot #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The vsock communication between guest and host was established with the firecracker pilot only for resume type registrations. For those it's required because you cannot mux one serial terminal between parallel applications running at the same time in the guest. So in resume mode each call has its own socket and channels. However, there is no reason to not also support that type of data flow between guest and host for one time calls which fires up the VM, starts the application and shuts down the VM. This commit adds support for forcing the vsock communication also for the simple app registration. The default stays on serial though.
schaefi
force-pushed
the
support_vsock_for_one_time_calls
branch
from
b8c9f1c to
84cf185
Compare
Add information about console settings and limitations with regards to firecracker VMs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The vsock communication between guest and host was established with the firecracker pilot only for resume type registrations. For those it's required because you cannot mux one serial terminal between parallel applications running at the same time in the guest. So in resume mode each call has its own socket and channels. However, there is no reason to not also support that type of data flow between guest and host for one time calls which fires up the VM, starts the application and shuts down the VM. This commit adds support for forcing the vsock communication also for the simple app registration. The default stays on serial though.