Fixed the runroot permission fixup #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
podman differentiates the runroot between root and rootless calls. If you initially call a flake as a user the initial podman database gets setup as rootless variant which also allows root based workloads without permission issues. However, if you do it the other way round the runroot is setup for root only which prevents the flake to be called as normal user. To handle this permission issues we have fix methods in the flake common code to change the permissions according to the calling user via sudo. The code to handle permissions for the runroot target has to apply for all users as we can't predict if the storage will be setup initially as rootless or for root only
rjschwei
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
podman differentiates the runroot between root and rootless calls. If you initially call a flake as a user the initial podman database gets setup as rootless variant which also allows root based workloads without permission issues. However, if you do it the other way round the runroot is setup for root only which prevents the flake to be called as normal user. To handle this permission issues we have fix methods in the flake common code to change the permissions according to the calling user via sudo. The code to handle permissions for the runroot target has to apply for all users as we can't predict if the storage will be setup initially as rootless or for root only