Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added actions to publish charts to github container registry #1201

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

a1994sc
Copy link
Contributor

@a1994sc a1994sc commented Jan 5, 2025

Description

Added actions to publish helm charts to ghcr.io/ot-container-kit/charts along side publishing charts to standard helm repo.

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist

  • Tests have been added/modified and all tests pass.
  • Functionality/bugs have been confirmed to be unchanged or fixed.
  • I have performed a self-review of my own code.
  • Documentation has been updated or added where necessary.

Additional Context

@drivebyer
Copy link
Collaborator

Could you please give some explanations for this PR, such as why it is needed?

@a1994sc
Copy link
Contributor Author

a1994sc commented Jan 6, 2025

So this PR enables pushing the helm charts to both the standard HTTP repo, and in addition the newer standard OCI repo. So there is no disruption to your current user-base.

The benefits for having the OCI version:

  • It is the newer standard
  • It is easier to proxy oci repos for corporate or limited connected environments as apposed to HTTP repo
  • For gitops tools, like flux, there is tooling around using OCI artifacts instead of HTTP calls

Copy link

codecov bot commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.54%. Comparing base (60ef5a2) to head (403ef23).
Report is 30 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1201      +/-   ##
==========================================
- Coverage   30.20%   29.54%   -0.67%     
==========================================
  Files          55       57       +2     
  Lines        6294     6601     +307     
==========================================
+ Hits         1901     1950      +49     
- Misses       4200     4459     +259     
+ Partials      193      192       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@a1994sc a1994sc changed the title Added actions to publish charts to github container registry feat: added actions to publish charts to github container registry Jan 14, 2025
@drivebyer drivebyer enabled auto-merge (squash) January 15, 2025 12:47
Copy link
Collaborator

@drivebyer drivebyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@drivebyer drivebyer merged commit bb4ed61 into OT-CONTAINER-KIT:master Jan 15, 2025
17 of 20 checks passed
@a1994sc
Copy link
Contributor Author

a1994sc commented Jan 15, 2025

Thank you! Feel free to ping me if you have any questions or concerns

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants