feat: rediscluster support hostnetwork and custom port #723

drivebyer · 2023-12-12T09:21:07Z

Description

Support hostnetwork for redis cluster mode.

ps: only support with clusterVersion: v6. Because we can not connect to hostnetwork pod with FQDN name

#183

Type of change

New feature (non-breaking change which adds functionality)

Checklist

Tests have been added/modified and all tests pass.
Functionality/bugs have been confirmed to be unchanged or fixed.
I have performed a self-review of my own code.
Documentation has been updated or added where necessary.

Additional Context

Here are test case:

create cluster:

2. check cluster:

3. cluster cluster out of k8s:

Signed-off-by: drivebyer <[email protected]>

codecov · 2023-12-12T09:52:27Z

Codecov Report

Attention: 40 lines in your changes are missing coverage. Please review.

Comparison is base (1e22658) 27.79% compared to head (2946c6b) 29.21%.
Report is 1 commits behind head on master.

Files	Patch %	Lines
k8sutils/cluster-scaling.go	0.00%	16 Missing ⚠️
k8sutils/statefulset.go	46.15%	6 Missing and 1 partial ⚠️
k8sutils/redis-cluster.go	40.00%	3 Missing ⚠️
k8sutils/redis-replication.go	0.00%	3 Missing ⚠️
k8sutils/redis-sentinel.go	0.00%	3 Missing ⚠️
k8sutils/redis-standalone.go	0.00%	3 Missing ⚠️
k8sutils/redis.go	75.00%	2 Missing ⚠️
k8sutils/services.go	60.00%	2 Missing ⚠️
controllers/rediscluster_controller.go	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #723      +/-   ##
==========================================
+ Coverage   27.79%   29.21%   +1.42%     
==========================================
  Files          18       18              
  Lines        3123     3135      +12     
==========================================
+ Hits          868      916      +48     
+ Misses       2228     2191      -37     
- Partials       27       28       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…R-KIT/redis-operator/pkg/util Signed-off-by: drivebyer <[email protected]>

Signed-off-by: drivebyer <[email protected]>

shubham-cmyk · 2023-12-12T10:10:17Z

@drivebyer Does this solves the issue for the connecting outside ?

api/v1beta2/rediscluster_types.go

drivebyer · 2023-12-12T10:18:40Z

@drivebyer Does this solves the issue for the connecting outside ?

Sure, see Additional Context of current PR.

shubham-cmyk · 2023-12-12T10:34:09Z

@drivebyer Does this solves the issue for the connecting outside ?

Sure, see Additional Context of current PR.

Looks Good.

Signed-off-by: drivebyer <[email protected]>

drivebyer · 2023-12-13T06:44:49Z

@shubham-cmyk ready now

Signed-off-by: drivebyer <[email protected]>

Signed-off-by: Shubham Gupta <[email protected]>

shubham-cmyk

LGTM

…IT#723) * add cr filed, default port to 6379 Signed-off-by: drivebyer <[email protected]> * replace with custom port Signed-off-by: drivebyer <[email protected]> * service custom port Signed-off-by: drivebyer <[email protected]> * make default to 6379 when reconcile old cluster Signed-off-by: drivebyer <[email protected]> * add e2e Signed-off-by: drivebyer <[email protected]> --------- Signed-off-by: drivebyer <[email protected]>

…IT#723) * add cr filed, default port to 6379 Signed-off-by: drivebyer <[email protected]> * replace with custom port Signed-off-by: drivebyer <[email protected]> * service custom port Signed-off-by: drivebyer <[email protected]> * make default to 6379 when reconcile old cluster Signed-off-by: drivebyer <[email protected]> * add e2e Signed-off-by: drivebyer <[email protected]> --------- Signed-off-by: drivebyer <[email protected]> Signed-off-by: Matt Robinson <[email protected]>

drivebyer added 5 commits December 12, 2023 17:18

add cr filed, default port to 6379

ee44c36

Signed-off-by: drivebyer <[email protected]>

replace with custom port

39da742

Signed-off-by: drivebyer <[email protected]>

service custom port

9646647

Signed-off-by: drivebyer <[email protected]>

make default to 6379 when reconcile old cluster

85dcfca

Signed-off-by: drivebyer <[email protected]>

add e2e

c1a116c

Signed-off-by: drivebyer <[email protected]>

drivebyer enabled auto-merge (squash) December 12, 2023 09:21

fix ut

4b8f0d7

Signed-off-by: drivebyer <[email protected]>

drivebyer added 2 commits December 12, 2023 17:59

fix error: no required module provides package github.com/OT-CONTAINE…

ce035ec

…R-KIT/redis-operator/pkg/util Signed-off-by: drivebyer <[email protected]>

remove

155194b

Signed-off-by: drivebyer <[email protected]>

drivebyer requested a review from shubham-cmyk December 12, 2023 10:06

drivebyer added the enhancement New feature or request label Dec 12, 2023

shubham-cmyk reviewed Dec 12, 2023

View reviewed changes

api/v1beta2/rediscluster_types.go Outdated Show resolved Hide resolved

drivebyer and others added 5 commits December 12, 2023 22:36

make port to pointer

c39faae

Signed-off-by: drivebyer <[email protected]>

fix e2e

d6579b5

Signed-off-by: drivebyer <[email protected]>

fix e2e

c24de14

Signed-off-by: drivebyer <[email protected]>

add unit test

cdd4853

Signed-off-by: drivebyer <[email protected]>

fix e2e

3d60b26

Signed-off-by: drivebyer <[email protected]>

drivebyer requested a review from shubham-cmyk December 13, 2023 02:56

drivebyer changed the title ~~feat: rediscluster support hostnetwork && custom port~~ feat: rediscluster support hostnetwork and custom port Dec 13, 2023

drivebyer and others added 6 commits December 13, 2023 22:18

add chainsaw e2e

635c0b4

Signed-off-by: drivebyer <[email protected]>

install redis cli

356103a

Signed-off-by: drivebyer <[email protected]>

setup redis action

0e9e1bd

Signed-off-by: drivebyer <[email protected]>

remove redis cli from CI

bacb271

Signed-off-by: Shubham Gupta <[email protected]>

fix

ee6018f

Signed-off-by: Shubham Gupta <[email protected]>

try on every node

c36ca8d

Signed-off-by: Shubham Gupta <[email protected]>

shubham-cmyk added 2 commits December 13, 2023 23:56

use cluster client

ac99b87

Signed-off-by: Shubham Gupta <[email protected]>

fix

2946c6b

Signed-off-by: Shubham Gupta <[email protected]>

shubham-cmyk approved these changes Dec 13, 2023

View reviewed changes

drivebyer merged commit adca068 into OT-CONTAINER-KIT:master Dec 13, 2023
25 checks passed

drivebyer had a problem deploying to release-image December 13, 2023 19:26 — with GitHub Actions Failure

drivebyer deleted the hostnetwork branch December 14, 2023 02:00

drivebyer mentioned this pull request Dec 15, 2023

feat: support exporter custom port #728

Merged

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: rediscluster support hostnetwork and custom port #723

feat: rediscluster support hostnetwork and custom port #723

drivebyer commented Dec 12, 2023 •

edited

Loading

codecov bot commented Dec 12, 2023 •

edited

Loading

shubham-cmyk commented Dec 12, 2023

drivebyer commented Dec 12, 2023

shubham-cmyk commented Dec 12, 2023

drivebyer commented Dec 13, 2023

shubham-cmyk left a comment

feat: rediscluster support hostnetwork and custom port #723

feat: rediscluster support hostnetwork and custom port #723

Conversation

drivebyer commented Dec 12, 2023 • edited Loading

codecov bot commented Dec 12, 2023 • edited Loading

Codecov Report

shubham-cmyk commented Dec 12, 2023

drivebyer commented Dec 12, 2023

shubham-cmyk commented Dec 12, 2023

drivebyer commented Dec 13, 2023

shubham-cmyk left a comment

Choose a reason for hiding this comment

drivebyer commented Dec 12, 2023 •

edited

Loading

codecov bot commented Dec 12, 2023 •

edited

Loading