feat: add environment to customize data pvc prefix #742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: drivebyer <[email protected]>
Signed-off-by: drivebyer <[email protected]>
drivebyer
force-pushed
the
sts-pvc-name
branch
from
b0fa1cf to
567f9aa
Compare
Signed-off-by: drivebyer <[email protected]>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #742 +/- ##
==========================================
+ Coverage 28.75% 28.81% +0.05%
==========================================
Files 19 19
Lines 3269 3273 +4
==========================================
+ Hits 940 943 +3
- Misses 2295 2296 +1
Partials 34 34 ☔ View full report in Codecov by Sentry. |
Signed-off-by: drivebyer <[email protected]>
Signed-off-by: drivebyer <[email protected]>
Signed-off-by: drivebyer <[email protected]>
Signed-off-by: drivebyer <[email protected]>
|
@shubham-cmyk PTAL |
drivebyer
had a problem deploying
to
release-image
GitHub Actions
Failure
mattrobinsonsre
pushed a commit
to mattrobinsonsre/redis-operator
that referenced
this pull request
Jul 11, 2024
) * support customize pvc template name Signed-off-by: drivebyer <[email protected]> * add test case Signed-off-by: drivebyer <[email protected]> * kubectl Signed-off-by: drivebyer <[email protected]> * wait operator ready Signed-off-by: drivebyer <[email protected]> * fix sleep Signed-off-by: drivebyer <[email protected]> * fix sleep Signed-off-by: drivebyer <[email protected]> * remove debug Signed-off-by: drivebyer <[email protected]> --------- Signed-off-by: drivebyer <[email protected]> Signed-off-by: Matt Robinson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #438
Type of change
Checklist
Additional Context