Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use operator built in probe script #859

Closed
wants to merge 1 commit into from

Conversation

drivebyer
Copy link
Collaborator

@drivebyer drivebyer commented Apr 1, 2024

Description

part of #766 .

This shell script is sourced from https://github.com/OT-CONTAINER-KIT/redis. By doing this, we can centralize the shell script management in the operator repository. This helps in separating it from https://github.com/OT-CONTAINER-KIT/redis.

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist

  • Tests have been added/modified and all tests pass.
  • Functionality/bugs have been confirmed to be unchanged or fixed.
  • I have performed a self-review of my own code.
  • Documentation has been updated or added where necessary.

Additional Context

Copy link

codecov bot commented Apr 1, 2024

Codecov Report

Attention: Patch coverage is 0% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 38.92%. Comparing base (d121d86) to head (f405307).
Report is 21 commits behind head on master.

Files Patch % Lines
k8sutils/statefulset.go 0.00% 12 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #859      +/-   ##
==========================================
+ Coverage   35.20%   38.92%   +3.72%     
==========================================
  Files          19       19              
  Lines        3213     2654     -559     
==========================================
- Hits         1131     1033      -98     
+ Misses       2015     1553     -462     
- Partials       67       68       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@drivebyer drivebyer requested a review from shubham-cmyk April 1, 2024 09:28
@drivebyer drivebyer enabled auto-merge (squash) April 1, 2024 09:28
@shubham-cmyk
Copy link
Member

Copy of #444

auto-merge was automatically disabled April 1, 2024 18:16

Pull request was closed

@drivebyer
Copy link
Collaborator Author

@shubham-cmyk
I actually noticed this pull request, but it seems to be taking a while to get merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants