Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warnings in compilation on Windows #41

Merged
merged 1 commit into from
Feb 23, 2025
Merged

Conversation

CodingALS
Copy link
Contributor

No description provided.

@CodingALS
Copy link
Contributor Author

@Oen44

@Oen44
Copy link
Collaborator

Oen44 commented Feb 23, 2025

Well... I kind of have few comments here.

  1. Stop using C-style casting, even when its already used in the sources. If you are editing them or adding new one then use C++ casting from standard lib.
  2. This luaL_newlib macro check and definition can be shortened
#ifndef luaL_newlib
#define luaL_newlib(x, y) luaL_register(x, LUA_BIT32LIBNAME, y)
#endif

@CodingALS
Copy link
Contributor Author

CodingALS commented Feb 23, 2025

Yeah, I just wanted to keep the default used in the source, since the preprocessor defined in the LIBs is different from the one used in the "standard source".

@Oen44 Oen44 merged commit a6369a1 into OTAcademy:master Feb 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants