Enhance getDelegationChainLength method with safe integer check and i…

…mproved error handling
OasisDEX · Feb 5, 2025 · e200d27 · e200d27
1 parent 5eefe17
commit e200d27
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 3 deletions.
diff --git a/sdk/armada-protocol-common/src/common/interfaces/IArmadaManagerGovernance.ts b/sdk/armada-protocol-common/src/common/interfaces/IArmadaManagerGovernance.ts
@@ -111,7 +111,7 @@ export interface IArmadaManagerGovernance {
    *
    * @param user The user
    *
-   * @returns The transaction information
+   * @returns The length of the delegation chain
    */
   getDelegationChainLength: (params: { user: IUser }) => Promise<number>
 }
diff --git a/sdk/armada-protocol-service/src/common/implementation/ArmadaManagerGovernance.ts b/sdk/armada-protocol-service/src/common/implementation/ArmadaManagerGovernance.ts
@@ -251,6 +251,10 @@ export class ArmadaManagerGovernance implements IArmadaManagerGovernance {
       functionName: 'getDelegationChainLength',
       args: [params.user.wallet.address.value],
     })
-    return Number(length.toString())
+    const num = Number(length.toString())
+    if (!Number.isSafeInteger(num)) {
+      throw new Error('Delegation chain length exceeds safe integer limits')
+    }
+    return num
   }
 }
diff --git a/sdk/sdk-server/src/armada-protocol-handlers/users/getDelegationChainLength.ts b/sdk/sdk-server/src/armada-protocol-handlers/users/getDelegationChainLength.ts
@@ -9,5 +9,10 @@ export const getDelegationChainLength = publicProcedure
     }),
   )
   .query(async (opts) => {
-    return await opts.ctx.armadaManager.governance.getDelegationChainLength(opts.input)
+    try {
+      return await opts.ctx.armadaManager.governance.getDelegationChainLength(opts.input)
+    } catch (error) {
+      console.error(`Failed to get delegation chain length: ${error}`)
+      throw new Error(`Failed to get delegation chain length: ${error}`)
+    }
   })