Remove temporary mainnet RPC and subgraph environment variables #722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalkthroughThe pull request removes temporary environment variables ( Changes
Possibly related PRs
Suggested reviewers
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
piotrwitek
previously approved these changes
Jan 31, 2025
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (5)
.env.template(0 hunks)apps/earn-protocol/app/api/rpcGateway/route.ts(2 hunks)apps/earn-protocol/app/server-handlers/position-history/index.ts(1 hunks)apps/earn-protocol/docker/Dockerfile(0 hunks)turbo.json(0 hunks)
💤 Files with no reviewable changes (3)
- .env.template
- apps/earn-protocol/docker/Dockerfile
- turbo.json
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: Build and Integration Test
- GitHub Check: Build and Unit Test
🔇 Additional comments (1)
apps/earn-protocol/app/api/rpcGateway/route.ts (1)
20-20: Verify RPC gateway URL securityDirect RPC URL usage needs security review.
✅ Verification successful
RPC gateway URL implementation is secure
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Check RPC gateway URL generation and validation ast-grep --pattern 'function getRpcGatewayUrl($_) { $$$ }'Length of output: 1114
Script:
#!/bin/bash # Check related RPC gateway functions ast-grep --pattern 'function getRemoteConfigWithCache($_) { $$$ }' ast-grep --pattern 'function getRpcGatewayBaseUrl() { $$$ }' ast-grep --pattern 'function resolveRpcGatewayUrl($_) { $$$ }'Length of output: 810
Script:
#!/bin/bash # Search for remote config and URL resolution rg -A 5 "getRemoteConfigWithCache|resolveRpcGatewayUrl" --type tsLength of output: 1781
apps/earn-protocol/app/server-handlers/position-history/index.ts
Outdated
Show resolved
Hide resolved
apps/earn-protocol/app/server-handlers/position-history/index.ts
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #722 +/- ##
==========================================
+ Coverage 66.85% 70.08% +3.23%
==========================================
Files 20 129 +109
Lines 178 1344 +1166
Branches 4 78 +74
==========================================
+ Hits 119 942 +823
- Misses 59 402 +343 ☔ View full report in Codecov by Sentry. |
…ion and improve network validation
piotrwitek
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eliminate the use of temporary mainnet RPC and subgraph environment variables to streamline configuration and improve code clarity.
Summary by CodeRabbit
Configuration Changes
Code Refactoring