Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update BoLD Submodule and Add Newly Supported Flags to BoLD Staker #2835

Merged
merged 24 commits into from
Jan 8, 2025

Conversation

rauljordan
Copy link
Contributor

This PR updates the BoLD submodule with commit d3f4d600abdacec800e9e27a429a730639233073 from the repo's main branch. The PR adds support for the following features:

  • Auto deposit when making txs that involve the stake token, enabled by default
  • Auto increase spending allowance for the rollup and challenge manager contracts, enabled by default
  • Support a custom withdrawal address for staking on assertions, default uses the sender's tx opts
  • Support delegated staking by calling newStake on startup for the validator, disabled by default
  • Support specifying a RPC block number such as latest, safe, or finalized for BoLD to read onchain data

@cla-bot cla-bot bot added the s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA. label Dec 16, 2024
@PlasmaPower
Copy link
Contributor

I think the nitro-testnode submodule was accidentally reverted in this PR

eljobe
eljobe previously approved these changes Dec 24, 2024
Copy link
Member

@eljobe eljobe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rauljordan
Copy link
Contributor Author

hi @eljobe this is ready again, thank you

Copy link

codecov bot commented Jan 2, 2025

Codecov Report

Attention: Patch coverage is 0% with 47 lines in your changes missing coverage. Please review.

Project coverage is 22.60%. Comparing base (4eaf47e) to head (a75a1cd).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2835      +/-   ##
==========================================
- Coverage   22.62%   22.60%   -0.03%     
==========================================
  Files         269      269              
  Lines       39738    39783      +45     
==========================================
  Hits         8992     8992              
- Misses      29272    29316      +44     
- Partials     1474     1475       +1     

eljobe
eljobe previously approved these changes Jan 6, 2025
Copy link
Member

@eljobe eljobe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rauljordan rauljordan changed the base branch from master to update_nightly_ci January 8, 2025 16:26
@tsahee tsahee merged commit f93c17f into update_nightly_ci Jan 8, 2025
1 check passed
@tsahee tsahee deleted the update-bold-dec-16 branch January 8, 2025 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design-approved s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants