Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cbindgen to both workflows #2890

Merged
merged 1 commit into from
Jan 20, 2025
Merged

Add cbindgen to both workflows #2890

merged 1 commit into from
Jan 20, 2025

Conversation

eljobe
Copy link
Member

@eljobe eljobe commented Jan 20, 2025

It turns out that the ci.yml workflow was also failing because of the removal of cbindgen from the Ubuntu 24.04 image used by the GitHub action runners.

This change also moves the installation of cbindgen earlier in the codequl-analysis.yml file and expands the scope of what is cached after a rust installation to include the cbindgen binary (which is installed in ~/.cargo/bin)

It turns out that the ci.yml workflow was also failing because of the removal of
cbindgen from the Ubuntu 24.04 image used by the GitHub action runners.

This change also moves the installation of cbindgen earlier in the
codequl-analysis.yml file and expands the scope of what is cached after a rust
installation to include the cbindgen binary (which is installed in ~/.cargo/bin)
Copy link
Member

@joshuacolvin0 joshuacolvin0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eljobe eljobe merged commit 0dc626d into master Jan 20, 2025
14 of 16 checks passed
@eljobe eljobe deleted the cbindgen-fix2 branch January 20, 2025 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants