Attempt to Reduce Flakiness of BoLD Virtual Block System Tests #2905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the state provider isn't able to do its job because the chain is lagging behind head, it's supposed to use a predefined error from the l2stateprovider package. Instead, the nitro implemention of the provider was using a redefinition of the error. While this coding error easily accounts for why there were a bunch of ERROR logs about the chain's not keeping up with the latest changes, it does not explain why the test is sometimes flaky. I suspect that the original commits in this PR were chasing the ERROR logs in the flaky tests, but that those were not the root cause of the test failures.
eljobe
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to reduce the ERROR log messages from bold system tests by using the standard l2stateprovider.ErrChainCatchingUp in the implementation of the bold state provider. Before this change, we would be seeing this with a ~20% occurrence
The problem was that, in poster.go and sync.go in the bold/assertions package the l2stateprovider.ErrChainCatchingUp error is caught and logged at a lower severity, INFO, but the bold state provider implementation was not using that error type, opting instead to use its own.
This should have the effect of having a couple-hundred fewer ERROR-level log messages. But, it may not actually reduce the flakiness of the these challenge tests.