Live tracing experimental MVP support for arbitrum nitro #2934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
daleksov
commented
Feb 7, 2025
| } | ||
|
|
||
| defer func() { | ||
| getVMConfig().Tracer.OnBlockEnd(outError) |
There was a problem hiding this comment.
This hook was missing a call, so I've added it manually here
daleksov
commented
Feb 7, 2025
| @@ -192,6 +218,16 @@ func ProduceBlockAdvanced( | |||
| } | |||
|
|
|||
| header := createNewHeader(lastBlockHeader, l1Info, arbState, chainConfig) | |||
|
|
|||
| getVMConfig().Tracer.OnBlockStart( | |||
There was a problem hiding this comment.
This hook was missing a call, so I've added it manually here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrating Tenderly Live Tracer into Arbitrum Nitro
Description:
This PR demonstrates our attempt to integrate live tracing into Arbitrum Nitro.
While we have a more complex system in place with the actual live tracer and a full build system around it, this PR highlights the core changes necessary to enable live tracing for Arb Nitro.
It serves as a foundation for understanding the key modifications required for this integration to happen.