Fossil client callback settles round #186
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes Summary
These changes consolidate the settlement process into the fossil callback, removing the need for a separate settlement step and ensuring atomic updates of L1 data and round settlement.
Core Changes
fossil_callback
inFossilClient
to return aFossilCallbackReturn
enum instead of voidsettle_round
function from Vault contract - settlement now happens directly infossil_client_callback
FossilCallbackReturn
enum with variants:RoundSettled(RoundSettledReturn)
FirstRoundInitialized
RoundSettledReturn
struct containingtotal_payout
Contract Changes
Vault Contract
fossil_client_callback
to:FossilCallbackReturn
variantFossilClient Contract
Test Changes
timeskip_and_settle_round
helper as settlement now happens in callbacksettle_option_round
and related methods from VaultFacadefossil_client_helpers.cairo