improve eslint config

OlivierZal · Apr 22, 2024 · abe13e0 · abe13e0
1 parent 654909f
commit abe13e0
Show file tree

Hide file tree

Showing 2 changed files with 55 additions and 4 deletions.
diff --git a/drivers/nuos/device.ts b/drivers/nuos/device.ts
@@ -436,13 +436,13 @@ class NuosDevice extends Device {
   async #plantSettings(postSettings: PostSettings): Promise<boolean> {
     if (Object.keys(postSettings).length) {
       try {
-        const { success } = (
+        const { success: isSuccess } = (
           await this.#aristonAPI.plantSettings(this.#id, postSettings)
         ).data
-        if (success) {
+        if (isSuccess) {
           await this.#setSettingCapabilities(postSettings)
         }
-        return success
+        return isSuccess
       } catch (error) {
         // Error handling is delegated to the interceptor
       }

diff --git a/eslint.config.js b/eslint.config.js
@@ -141,7 +141,58 @@ module.exports = tsEslint.config(
           },
         },
       ],
-      '@typescript-eslint/naming-convention': 'off',
+      '@typescript-eslint/naming-convention': [
+        'error',
+        {
+          filter: {
+            match: true,
+            regex: '^[a-z]+(?:_[a-z0-9]+)*\\.[a-z]+(?:_[a-z0-9]+)*$',
+          },
+          format: null,
+          selector: [
+            'objectLiteralMethod',
+            'objectLiteralProperty',
+            'typeProperty',
+          ],
+        },
+        {
+          format: ['camelCase', 'snake_case'],
+          selector: 'objectLiteralProperty',
+        },
+        {
+          format: ['camelCase', 'PascalCase', 'snake_case'],
+          selector: 'typeProperty',
+        },
+        {
+          format: ['camelCase', 'PascalCase'],
+          selector: 'import',
+        },
+        {
+          format: ['PascalCase'],
+          prefix: ['can', 'did', 'has', 'is', 'should', 'will'],
+          selector: 'variable',
+          types: ['boolean'],
+        },
+        {
+          format: ['camelCase'],
+          modifiers: ['global'],
+          selector: 'variable',
+          types: ['function'],
+        },
+        {
+          format: ['camelCase', 'UPPER_CASE'],
+          modifiers: ['global'],
+          selector: 'variable',
+        },
+        {
+          format: ['PascalCase'],
+          selector: 'typeLike',
+        },
+        {
+          format: ['camelCase'],
+          selector: 'default',
+        },
+      ],
       '@typescript-eslint/no-explicit-any': ['error', { ignoreRestArgs: true }],
       '@typescript-eslint/no-magic-numbers': ['error', { ignoreEnums: true }],
       '@typescript-eslint/no-unused-vars': [