Skip to content

Commit

Permalink
add override
Browse files Browse the repository at this point in the history
  • Loading branch information
Olivier Zalmanski committed Apr 22, 2024
1 parent 14db019 commit da9783c
Show file tree
Hide file tree
Showing 5 changed files with 24 additions and 24 deletions.
2 changes: 1 addition & 1 deletion app.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import { Settings as LuxonSettings } from 'luxon'
export = class AristonApp extends App {
public readonly aristonAPI = new AristonAPI(this.homey.settings, this)

public async onInit(): Promise<void> {
public override async onInit(): Promise<void> {
LuxonSettings.defaultZone = this.homey.clock.getTimezone()
await this.aristonAPI.applyLogin()
}
Expand Down
4 changes: 2 additions & 2 deletions decorators/addToLogs.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,11 @@ const addToLogs =
<T extends new (...args: any[]) => SimpleClass>(...logs: string[]) =>
(target: T, context: ClassDecoratorContext<T>): T => {
class LogsDecorator extends target {
public error(...args: unknown[]): void {
public override error(...args: unknown[]): void {
this.#commonLog('error', ...args)
}

public log(...args: unknown[]): void {
public override log(...args: unknown[]): void {
this.#commonLog('log', ...args)
}

Expand Down
35 changes: 17 additions & 18 deletions drivers/nuos/device.ts
Original file line number Diff line number Diff line change
Expand Up @@ -159,35 +159,35 @@ class NuosDevice extends Device {

readonly #id = (this.getData() as DeviceDetails['data']).id

public async addCapability(capability: string): Promise<void> {
public override async addCapability(capability: string): Promise<void> {
if (!this.hasCapability(capability)) {
await super.addCapability(capability)
}
}

public getCapabilityOptions<K extends keyof CapabilityOptionsEntries>(
capability: K,
): CapabilityOptionsEntries[K] {
public override getCapabilityOptions<
K extends keyof CapabilityOptionsEntries,
>(capability: K): CapabilityOptionsEntries[K] {
return super.getCapabilityOptions(capability) as CapabilityOptionsEntries[K]
}

public getCapabilityValue<K extends keyof Capabilities>(
public override getCapabilityValue<K extends keyof Capabilities>(
capability: K,
): Capabilities[K] {
return super.getCapabilityValue(capability) as Capabilities[K]
}

public getSetting<K extends keyof Settings>(
public override getSetting<K extends keyof Settings>(
setting: K,
): NonNullable<Settings[K]> {
return super.getSetting(setting) as NonNullable<Settings[K]>
}

public onDeleted(): void {
public override onDeleted(): void {
this.homey.clearTimeout(this.#syncTimeout)
}

public async onInit(): Promise<void> {
public override async onInit(): Promise<void> {
await this.setWarning(null)
await this.#handleCapabilities()
this.#registerCapabilityListeners()
Expand All @@ -211,7 +211,7 @@ class NuosDevice extends Device {
)
}

public async onSettings({
public override async onSettings({
changedKeys,
newSettings,
}: {
Expand Down Expand Up @@ -240,25 +240,24 @@ class NuosDevice extends Device {
}
}

public async onUninit(): Promise<void> {
public override async onUninit(): Promise<void> {
this.onDeleted()
return Promise.resolve()
}

public async removeCapability(capability: string): Promise<void> {
public override async removeCapability(capability: string): Promise<void> {
if (this.hasCapability(capability)) {
await super.removeCapability(capability)
}
}

public async setCapabilityOptions<K extends keyof CapabilityOptionsEntries>(
capability: K,
options: CapabilityOptionsEntries[K],
): Promise<void> {
public override async setCapabilityOptions<
K extends keyof CapabilityOptionsEntries,
>(capability: K, options: CapabilityOptionsEntries[K]): Promise<void> {
await super.setCapabilityOptions(capability, options)
}

public async setCapabilityValue<K extends keyof Capabilities>(
public override async setCapabilityValue<K extends keyof Capabilities>(
capability: K,
value: Capabilities[K],
): Promise<void> {
Expand All @@ -268,7 +267,7 @@ class NuosDevice extends Device {
}
}

public async setSettings(settings: Settings): Promise<void> {
public override async setSettings(settings: Settings): Promise<void> {
const newSettings = Object.fromEntries(
Object.entries(settings).filter(
([key, value]) => value !== this.getSetting(key as keyof Settings),
Expand All @@ -284,7 +283,7 @@ class NuosDevice extends Device {
}
}

public async setWarning(warning: string | null): Promise<void> {
public override async setWarning(warning: string | null): Promise<void> {
if (warning !== null) {
await super.setWarning(warning)
}
Expand Down
6 changes: 3 additions & 3 deletions drivers/nuos/driver.ts
Original file line number Diff line number Diff line change
Expand Up @@ -13,12 +13,12 @@ export = class NuosDriver extends Driver {
this.manifest as ManifestDriver
).capabilities.filter((capability) => capability.startsWith('onoff.'))

public async onInit(): Promise<void> {
public override async onInit(): Promise<void> {
this.#registerRunListeners()
return Promise.resolve()
}

public async onPair(session: PairSession): Promise<void> {
public override async onPair(session: PairSession): Promise<void> {
session.setHandler('showView', async (view) => {
if (view === 'loading') {
if (await this.#aristonAPI.applyLogin()) {
Expand All @@ -35,7 +35,7 @@ export = class NuosDriver extends Driver {
return Promise.resolve()
}

public async onRepair(session: PairSession): Promise<void> {
public override async onRepair(session: PairSession): Promise<void> {
session.setHandler('login', async (data: LoginCredentials) =>
this.#aristonAPI.applyLogin(data),
)
Expand Down
1 change: 1 addition & 0 deletions tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
"extends": "@tsconfig/node21/tsconfig.json",
"compilerOptions": {
"lib": ["ESNext", "DOM"],
"noImplicitOverride": true,
"outDir": ".homeybuild/",
"sourceMap": true
}
Expand Down

0 comments on commit da9783c

Please sign in to comment.